Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'Documents' from plural to singular in DocEvent #612

Closed
chacha912 opened this issue Aug 18, 2023 · 4 comments · Fixed by #613
Closed

Change 'Documents' from plural to singular in DocEvent #612

chacha912 opened this issue Aug 18, 2023 · 4 comments · Fixed by #613
Labels
protocol changed 📝 Whether the protocol has changed sdk ⚒️

Comments

@chacha912
Copy link
Contributor

Description:

Change "documents" to "document" in DocEvent (since the WatchDocument API has been updated to operate on a single document: yorkie-team/yorkie-js-sdk#480).

Related: #609

Why: Cleanup DocEvent
@chacha912 chacha912 mentioned this issue Aug 18, 2023
Merged
2 tasks
@hackerwins hackerwins added protocol changed 📝 Whether the protocol has changed sdk ⚒️ labels Aug 18, 2023
@hackerwins hackerwins reopened this Aug 18, 2023
@hackerwins
Copy link
Member

@chacha912 Do we need to apply this update to other SDKs?

@chacha912
Copy link
Contributor Author

@hackerwins Yes, due to a protocol change, modifications are required in other SDKs as well.

@hackerwins
Copy link
Member

hackerwins commented Aug 18, 2023 •
edited
Loading

Tasks:

@hackerwins
Copy link
Member

@chacha912 How about doing #498 together?

This was referenced Aug 18, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol changed 📝 Whether the protocol has changed sdk ⚒️
Projects
No open projects
Yorkie Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change 'Documents' from plural to singular in DocEvent yorkie-team/yorkie
2 participants
@hackerwins @chacha912