Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Documents' from plural to singular in DocEvent #616

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Aug 18, 2023

What this PR does / why we need it?

Change "documents" to "document" in DocEvent

Any background context you want to provide?

There were previous proto changes in the js-sdk, so I have set the target branch to "concurrent-case-handling."

What are the relevant tickets?

Related yorkie-team/yorkie#612

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins added cleanup 🧹 Paying off technical debt protocol changed 📝 Whether the protocol has changed labels Aug 18, 2023
@hackerwins hackerwins merged commit c9d50cb into concurrent-case-handling Aug 18, 2023
@hackerwins hackerwins deleted the cleanup-docevent-proto branch August 18, 2023 06:43
@chacha912 chacha912 mentioned this pull request Aug 21, 2023
2 tasks
@chacha912 chacha912 restored the cleanup-docevent-proto branch August 21, 2023 00:39
@chacha912 chacha912 deleted the cleanup-docevent-proto branch August 21, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt protocol changed 📝 Whether the protocol has changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants