Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ChangePack creation logic for p.Clear() when document detach #1055

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Improve ChangePack creation logic for p.Clear() when document detach #1055

wants to merge 2 commits into from
+75 −15

Conversation

raararaara
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Oct 31, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@raararaara raararaara changed the title Improve ChangePack creation logic for p.Clear() operation Improve ChangePack creation logic for p.Clear() when document detach Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (4485a28) to head (5aacd18).

Files with missing lines Patch % Lines
server/backend/database/mongo/client.go 0.00% 18 Missing ⚠️
server/rpc/cluster_server.go 0.00% 16 Missing ⚠️
server/backend/database/memory/database.go 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
- Coverage   46.76%   46.60%   -0.16%     
==========================================
  Files          82       82              
  Lines       12001    12041      +40     
==========================================
  Hits         5612     5612              
- Misses       5826     5866      +40     
  Partials      563      563

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions[bot]
github-actions bot reviewed Oct 31, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: 5aacd18 Previous: a8605ef Ratio
BenchmarkDocument/constructor_test 1504 ns/op 1337 B/op 24 allocs/op 1502 ns/op 1337 B/op 24 allocs/op 1.00
BenchmarkDocument/constructor_test - ns/op 1504 ns/op 1502 ns/op 1.00
BenchmarkDocument/constructor_test - B/op 1337 B/op 1337 B/op 1
BenchmarkDocument/constructor_test - allocs/op 24 allocs/op 24 allocs/op 1
BenchmarkDocument/status_test 964.8 ns/op 1305 B/op 22 allocs/op 962.5 ns/op 1305 B/op 22 allocs/op 1.00
BenchmarkDocument/status_test - ns/op 964.8 ns/op 962.5 ns/op 1.00
BenchmarkDocument/status_test - B/op 1305 B/op 1305 B/op 1
BenchmarkDocument/status_test - allocs/op 22 allocs/op 22 allocs/op 1
BenchmarkDocument/equals_test 7769 ns/op 7529 B/op 134 allocs/op 7816 ns/op 7529 B/op 134 allocs/op 0.99
BenchmarkDocument/equals_test - ns/op 7769 ns/op 7816 ns/op 0.99
BenchmarkDocument/equals_test - B/op 7529 B/op 7529 B/op 1
BenchmarkDocument/equals_test - allocs/op 134 allocs/op 134 allocs/op 1
BenchmarkDocument/nested_update_test 17029 ns/op 12395 B/op 264 allocs/op 17129 ns/op 12395 B/op 264 allocs/op 0.99
BenchmarkDocument/nested_update_test - ns/op 17029 ns/op 17129 ns/op 0.99
BenchmarkDocument/nested_update_test - B/op 12395 B/op 12395 B/op 1
BenchmarkDocument/nested_update_test - allocs/op 264 allocs/op 264 allocs/op 1
BenchmarkDocument/delete_test 23118 ns/op 15924 B/op 347 allocs/op 25918 ns/op 15923 B/op 347 allocs/op 0.89
BenchmarkDocument/delete_test - ns/op 23118 ns/op 25918 ns/op 0.89
BenchmarkDocument/delete_test - B/op 15924 B/op 15923 B/op 1.00
BenchmarkDocument/delete_test - allocs/op 347 allocs/op 347 allocs/op 1
BenchmarkDocument/object_test 9378 ns/op 7073 B/op 122 allocs/op 8806 ns/op 7073 B/op 122 allocs/op 1.06
BenchmarkDocument/object_test - ns/op 9378 ns/op 8806 ns/op 1.06
BenchmarkDocument/object_test - B/op 7073 B/op 7073 B/op 1
BenchmarkDocument/object_test - allocs/op 122 allocs/op 122 allocs/op 1
BenchmarkDocument/array_test 29659 ns/op 12203 B/op 278 allocs/op 30036 ns/op 12203 B/op 278 allocs/op 0.99
BenchmarkDocument/array_test - ns/op 29659 ns/op 30036 ns/op 0.99
BenchmarkDocument/array_test - B/op 12203 B/op 12203 B/op 1
BenchmarkDocument/array_test - allocs/op 278 allocs/op 278 allocs/op 1
BenchmarkDocument/text_test 32516 ns/op 15326 B/op 492 allocs/op 32282 ns/op 15323 B/op 492 allocs/op 1.01
BenchmarkDocument/text_test - ns/op 32516 ns/op 32282 ns/op 1.01
BenchmarkDocument/text_test - B/op 15326 B/op 15323 B/op 1.00
BenchmarkDocument/text_test - allocs/op 492 allocs/op 492 allocs/op 1
BenchmarkDocument/text_composition_test 30644 ns/op 18716 B/op 504 allocs/op 30559 ns/op 18718 B/op 504 allocs/op 1.00
BenchmarkDocument/text_composition_test - ns/op 30644 ns/op 30559 ns/op 1.00
BenchmarkDocument/text_composition_test - B/op 18716 B/op 18718 B/op 1.00
BenchmarkDocument/text_composition_test - allocs/op 504 allocs/op 504 allocs/op 1
BenchmarkDocument/rich_text_test 84089 ns/op 40180 B/op 1183 allocs/op 84716 ns/op 40180 B/op 1183 allocs/op 0.99
BenchmarkDocument/rich_text_test - ns/op 84089 ns/op 84716 ns/op 0.99
BenchmarkDocument/rich_text_test - B/op 40180 B/op 40180 B/op 1
BenchmarkDocument/rich_text_test - allocs/op 1183 allocs/op 1183 allocs/op 1
BenchmarkDocument/counter_test 18600 ns/op 11874 B/op 258 allocs/op 18570 ns/op 11875 B/op 258 allocs/op 1.00
BenchmarkDocument/counter_test - ns/op 18600 ns/op 18570 ns/op 1.00
BenchmarkDocument/counter_test - B/op 11874 B/op 11875 B/op 1.00
BenchmarkDocument/counter_test - allocs/op 258 allocs/op 258 allocs/op 1
BenchmarkDocument/text_edit_gc_100 1319019 ns/op 872535 B/op 17282 allocs/op 1322038 ns/op 872562 B/op 17282 allocs/op 1.00
BenchmarkDocument/text_edit_gc_100 - ns/op 1319019 ns/op 1322038 ns/op 1.00
BenchmarkDocument/text_edit_gc_100 - B/op 872535 B/op 872562 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17282 allocs/op 17282 allocs/op 1
BenchmarkDocument/text_edit_gc_1000 49918138 ns/op 50546865 B/op 186739 allocs/op 50761369 ns/op 50546440 B/op 186741 allocs/op 0.98
BenchmarkDocument/text_edit_gc_1000 - ns/op 49918138 ns/op 50761369 ns/op 0.98
BenchmarkDocument/text_edit_gc_1000 - B/op 50546865 B/op 50546440 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 186739 allocs/op 186741 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 1941105 ns/op 1589039 B/op 15951 allocs/op 1927409 ns/op 1589031 B/op 15951 allocs/op 1.01
BenchmarkDocument/text_split_gc_100 - ns/op 1941105 ns/op 1927409 ns/op 1.01
BenchmarkDocument/text_split_gc_100 - B/op 1589039 B/op 1589031 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 15951 allocs/op 15951 allocs/op 1
BenchmarkDocument/text_split_gc_1000 116722244 ns/op 141482452 B/op 186145 allocs/op 116138414 ns/op 141483012 B/op 186149 allocs/op 1.01
BenchmarkDocument/text_split_gc_1000 - ns/op 116722244 ns/op 116138414 ns/op 1.01
BenchmarkDocument/text_split_gc_1000 - B/op 141482452 B/op 141483012 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 186145 allocs/op 186149 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 15957976 ns/op 10214085 B/op 55687 allocs/op 15920627 ns/op 10214378 B/op 55687 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 15957976 ns/op 15920627 ns/op 1.00
BenchmarkDocument/text_delete_all_10000 - B/op 10214085 B/op 10214378 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 55687 allocs/op 55687 allocs/op 1
BenchmarkDocument/text_delete_all_100000 305202570 ns/op 142961324 B/op 561682 allocs/op 286191957 ns/op 142994620 B/op 561750 allocs/op 1.07
BenchmarkDocument/text_delete_all_100000 - ns/op 305202570 ns/op 286191957 ns/op 1.07
BenchmarkDocument/text_delete_all_100000 - B/op 142961324 B/op 142994620 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 561682 allocs/op 561750 allocs/op 1.00
BenchmarkDocument/text_100 220317 ns/op 120491 B/op 5182 allocs/op 218714 ns/op 120489 B/op 5182 allocs/op 1.01
BenchmarkDocument/text_100 - ns/op 220317 ns/op 218714 ns/op 1.01
BenchmarkDocument/text_100 - B/op 120491 B/op 120489 B/op 1.00
BenchmarkDocument/text_100 - allocs/op 5182 allocs/op 5182 allocs/op 1
BenchmarkDocument/text_1000 2397095 ns/op 1171280 B/op 51086 allocs/op 2378530 ns/op 1171276 B/op 51086 allocs/op 1.01
BenchmarkDocument/text_1000 - ns/op 2397095 ns/op 2378530 ns/op 1.01
BenchmarkDocument/text_1000 - B/op 1171280 B/op 1171276 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 51086 allocs/op 51086 allocs/op 1
BenchmarkDocument/array_1000 1229295 ns/op 1091694 B/op 11834 allocs/op 1209815 ns/op 1091673 B/op 11834 allocs/op 1.02
BenchmarkDocument/array_1000 - ns/op 1229295 ns/op 1209815 ns/op 1.02
BenchmarkDocument/array_1000 - B/op 1091694 B/op 1091673 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11834 allocs/op 11834 allocs/op 1
BenchmarkDocument/array_10000 13534526 ns/op 9801064 B/op 120301 allocs/op 13289936 ns/op 9800596 B/op 120299 allocs/op 1.02
BenchmarkDocument/array_10000 - ns/op 13534526 ns/op 13289936 ns/op 1.02
BenchmarkDocument/array_10000 - B/op 9801064 B/op 9800596 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120301 allocs/op 120299 allocs/op 1.00
BenchmarkDocument/array_gc_100 157562 ns/op 133292 B/op 1267 allocs/op 146508 ns/op 133289 B/op 1267 allocs/op 1.08
BenchmarkDocument/array_gc_100 - ns/op 157562 ns/op 146508 ns/op 1.08
BenchmarkDocument/array_gc_100 - B/op 133292 B/op 133289 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1267 allocs/op 1267 allocs/op 1
BenchmarkDocument/array_gc_1000 1419108 ns/op 1159847 B/op 12883 allocs/op 1410555 ns/op 1159867 B/op 12883 allocs/op 1.01
BenchmarkDocument/array_gc_1000 - ns/op 1419108 ns/op 1410555 ns/op 1.01
BenchmarkDocument/array_gc_1000 - B/op 1159847 B/op 1159867 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12883 allocs/op 12883 allocs/op 1
BenchmarkDocument/counter_1000 209042 ns/op 193336 B/op 5773 allocs/op 199922 ns/op 193335 B/op 5773 allocs/op 1.05
BenchmarkDocument/counter_1000 - ns/op 209042 ns/op 199922 ns/op 1.05
BenchmarkDocument/counter_1000 - B/op 193336 B/op 193335 B/op 1.00
BenchmarkDocument/counter_1000 - allocs/op 5773 allocs/op 5773 allocs/op 1
BenchmarkDocument/counter_10000 2205943 ns/op 2088267 B/op 59780 allocs/op 2161503 ns/op 2088251 B/op 59780 allocs/op 1.02
BenchmarkDocument/counter_10000 - ns/op 2205943 ns/op 2161503 ns/op 1.02
BenchmarkDocument/counter_10000 - B/op 2088267 B/op 2088251 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 59780 allocs/op 59780 allocs/op 1
BenchmarkDocument/object_1000 1416170 ns/op 1428497 B/op 9851 allocs/op 1370491 ns/op 1428241 B/op 9850 allocs/op 1.03
BenchmarkDocument/object_1000 - ns/op 1416170 ns/op 1370491 ns/op 1.03
BenchmarkDocument/object_1000 - B/op 1428497 B/op 1428241 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9851 allocs/op 9850 allocs/op 1.00
BenchmarkDocument/object_10000 15317154 ns/op 12167627 B/op 100568 allocs/op 15254780 ns/op 12168513 B/op 100572 allocs/op 1.00
BenchmarkDocument/object_10000 - ns/op 15317154 ns/op 15254780 ns/op 1.00
BenchmarkDocument/object_10000 - B/op 12167627 B/op 12168513 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 100568 allocs/op 100572 allocs/op 1.00
BenchmarkDocument/tree_100 1040968 ns/op 943958 B/op 6103 allocs/op 1020342 ns/op 943956 B/op 6103 allocs/op 1.02
BenchmarkDocument/tree_100 - ns/op 1040968 ns/op 1020342 ns/op 1.02
BenchmarkDocument/tree_100 - B/op 943958 B/op 943956 B/op 1.00
BenchmarkDocument/tree_100 - allocs/op 6103 allocs/op 6103 allocs/op 1
BenchmarkDocument/tree_1000 74324806 ns/op 86460613 B/op 60117 allocs/op 72748940 ns/op 86460446 B/op 60116 allocs/op 1.02
BenchmarkDocument/tree_1000 - ns/op 74324806 ns/op 72748940 ns/op 1.02
BenchmarkDocument/tree_1000 - B/op 86460613 B/op 86460446 B/op 1.00
BenchmarkDocument/tree_1000 - allocs/op 60117 allocs/op 60116 allocs/op 1.00
BenchmarkDocument/tree_10000 9297881605 ns/op 8580672144 B/op 600236 allocs/op 9344816675 ns/op 8580671488 B/op 600224 allocs/op 0.99
BenchmarkDocument/tree_10000 - ns/op 9297881605 ns/op 9344816675 ns/op 0.99
BenchmarkDocument/tree_10000 - B/op 8580672144 B/op 8580671488 B/op 1.00
BenchmarkDocument/tree_10000 - allocs/op 600236 allocs/op 600224 allocs/op 1.00
BenchmarkDocument/tree_delete_all_1000 74676421 ns/op 87510171 B/op 75271 allocs/op 73752345 ns/op 87509262 B/op 75268 allocs/op 1.01
BenchmarkDocument/tree_delete_all_1000 - ns/op 74676421 ns/op 73752345 ns/op 1.01
BenchmarkDocument/tree_delete_all_1000 - B/op 87510171 B/op 87509262 B/op 1.00
BenchmarkDocument/tree_delete_all_1000 - allocs/op 75271 allocs/op 75268 allocs/op 1.00
BenchmarkDocument/tree_edit_gc_100 3742945 ns/op 4148265 B/op 15146 allocs/op 3751719 ns/op 4148278 B/op 15147 allocs/op 1.00
BenchmarkDocument/tree_edit_gc_100 - ns/op 3742945 ns/op 3751719 ns/op 1.00
BenchmarkDocument/tree_edit_gc_100 - B/op 4148265 B/op 4148278 B/op 1.00
BenchmarkDocument/tree_edit_gc_100 - allocs/op 15146 allocs/op 15147 allocs/op 1.00
BenchmarkDocument/tree_edit_gc_1000 297577550 ns/op 383744944 B/op 154854 allocs/op 293866389 ns/op 383744620 B/op 154850 allocs/op 1.01
BenchmarkDocument/tree_edit_gc_1000 - ns/op 297577550 ns/op 293866389 ns/op 1.01
BenchmarkDocument/tree_edit_gc_1000 - B/op 383744944 B/op 383744620 B/op 1.00
BenchmarkDocument/tree_edit_gc_1000 - allocs/op 154854 allocs/op 154850 allocs/op 1.00
BenchmarkDocument/tree_split_gc_100 2500810 ns/op 2413033 B/op 11131 allocs/op 2480875 ns/op 2412997 B/op 11131 allocs/op 1.01
BenchmarkDocument/tree_split_gc_100 - ns/op 2500810 ns/op 2480875 ns/op 1.01
BenchmarkDocument/tree_split_gc_100 - B/op 2413033 B/op 2412997 B/op 1.00
BenchmarkDocument/tree_split_gc_100 - allocs/op 11131 allocs/op 11131 allocs/op 1
BenchmarkDocument/tree_split_gc_1000 181873950 ns/op 222253460 B/op 122002 allocs/op 177728909 ns/op 222252022 B/op 121998 allocs/op 1.02
BenchmarkDocument/tree_split_gc_1000 - ns/op 181873950 ns/op 177728909 ns/op 1.02
BenchmarkDocument/tree_split_gc_1000 - B/op 222253460 B/op 222252022 B/op 1.00
BenchmarkDocument/tree_split_gc_1000 - allocs/op 122002 allocs/op 121998 allocs/op 1.00
BenchmarkRPC/client_to_server 424166107 ns/op 20088968 B/op 228473 allocs/op 417618189 ns/op 20917842 B/op 228433 allocs/op 1.02
BenchmarkRPC/client_to_server - ns/op 424166107 ns/op 417618189 ns/op 1.02
BenchmarkRPC/client_to_server - B/op 20088968 B/op 20917842 B/op 0.96
BenchmarkRPC/client_to_server - allocs/op 228473 allocs/op 228433 allocs/op 1.00
BenchmarkRPC/client_to_client_via_server 788388218 ns/op 40538048 B/op 475851 allocs/op 779122100 ns/op 42257820 B/op 476664 allocs/op 1.01
BenchmarkRPC/client_to_client_via_server - ns/op 788388218 ns/op 779122100 ns/op 1.01
BenchmarkRPC/client_to_client_via_server - B/op 40538048 B/op 42257820 B/op 0.96
BenchmarkRPC/client_to_client_via_server - allocs/op 475851 allocs/op 476664 allocs/op 1.00
BenchmarkRPC/attach_large_document 1364925598 ns/op 1919618064 B/op 13823 allocs/op 1259370310 ns/op 1932711680 B/op 13568 allocs/op 1.08
BenchmarkRPC/attach_large_document - ns/op 1364925598 ns/op 1259370310 ns/op 1.08
BenchmarkRPC/attach_large_document - B/op 1919618064 B/op 1932711680 B/op 0.99
BenchmarkRPC/attach_large_document - allocs/op 13823 allocs/op 13568 allocs/op 1.02
BenchmarkRPC/adminCli_to_server 537468170 ns/op 35955672 B/op 289552 allocs/op 526685870 ns/op 35957480 B/op 289555 allocs/op 1.02
BenchmarkRPC/adminCli_to_server - ns/op 537468170 ns/op 526685870 ns/op 1.02
BenchmarkRPC/adminCli_to_server - B/op 35955672 B/op 35957480 B/op 1.00
BenchmarkRPC/adminCli_to_server - allocs/op 289552 allocs/op 289555 allocs/op 1.00
BenchmarkLocker 65.54 ns/op 16 B/op 1 allocs/op 64.28 ns/op 16 B/op 1 allocs/op 1.02
BenchmarkLocker - ns/op 65.54 ns/op 64.28 ns/op 1.02
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel 38.48 ns/op 0 B/op 0 allocs/op 38.39 ns/op 0 B/op 0 allocs/op 1.00
BenchmarkLockerParallel - ns/op 38.48 ns/op 38.39 ns/op 1.00
BenchmarkLockerParallel - B/op 0 B/op 0 B/op 1
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkLockerMoreKeys 147.7 ns/op 15 B/op 0 allocs/op 145.9 ns/op 15 B/op 0 allocs/op 1.01
BenchmarkLockerMoreKeys - ns/op 147.7 ns/op 145.9 ns/op 1.01
BenchmarkLockerMoreKeys - B/op 15 B/op 15 B/op 1
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkChange/Push_10_Changes 4452427 ns/op 142995 B/op 1570 allocs/op 4368453 ns/op 143556 B/op 1571 allocs/op 1.02
BenchmarkChange/Push_10_Changes - ns/op 4452427 ns/op 4368453 ns/op 1.02
BenchmarkChange/Push_10_Changes - B/op 142995 B/op 143556 B/op 1.00
BenchmarkChange/Push_10_Changes - allocs/op 1570 allocs/op 1571 allocs/op 1.00
BenchmarkChange/Push_100_Changes 16325945 ns/op 698763 B/op 8187 allocs/op 16247890 ns/op 697742 B/op 8185 allocs/op 1.00
BenchmarkChange/Push_100_Changes - ns/op 16325945 ns/op 16247890 ns/op 1.00
BenchmarkChange/Push_100_Changes - B/op 698763 B/op 697742 B/op 1.00
BenchmarkChange/Push_100_Changes - allocs/op 8187 allocs/op 8185 allocs/op 1.00
BenchmarkChange/Push_1000_Changes 128207875 ns/op 6825768 B/op 77156 allocs/op 131794613 ns/op 6824378 B/op 77157 allocs/op 0.97
BenchmarkChange/Push_1000_Changes - ns/op 128207875 ns/op 131794613 ns/op 0.97
BenchmarkChange/Push_1000_Changes - B/op 6825768 B/op 6824378 B/op 1.00
BenchmarkChange/Push_1000_Changes - allocs/op 77156 allocs/op 77157 allocs/op 1.00
BenchmarkChange/Pull_10_Changes 3642219 ns/op 123661 B/op 1403 allocs/op 3588130 ns/op 123990 B/op 1403 allocs/op 1.02
BenchmarkChange/Pull_10_Changes - ns/op 3642219 ns/op 3588130 ns/op 1.02
BenchmarkChange/Pull_10_Changes - B/op 123661 B/op 123990 B/op 1.00
BenchmarkChange/Pull_10_Changes - allocs/op 1403 allocs/op 1403 allocs/op 1
BenchmarkChange/Pull_100_Changes 5110447 ns/op 350805 B/op 4947 allocs/op 5098234 ns/op 351524 B/op 4947 allocs/op 1.00
BenchmarkChange/Pull_100_Changes - ns/op 5110447 ns/op 5098234 ns/op 1.00
BenchmarkChange/Pull_100_Changes - B/op 350805 B/op 351524 B/op 1.00
BenchmarkChange/Pull_100_Changes - allocs/op 4947 allocs/op 4947 allocs/op 1
BenchmarkChange/Pull_1000_Changes 10230441 ns/op 2220169 B/op 42667 allocs/op 10205605 ns/op 2221031 B/op 42668 allocs/op 1.00
BenchmarkChange/Pull_1000_Changes - ns/op 10230441 ns/op 10205605 ns/op 1.00
BenchmarkChange/Pull_1000_Changes - B/op 2220169 B/op 2221031 B/op 1.00
BenchmarkChange/Pull_1000_Changes - allocs/op 42667 allocs/op 42668 allocs/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot 18196651 ns/op 808117 B/op 8188 allocs/op 18356423 ns/op 813586 B/op 8187 allocs/op 0.99
BenchmarkSnapshot/Push_3KB_snapshot - ns/op 18196651 ns/op 18356423 ns/op 0.99
BenchmarkSnapshot/Push_3KB_snapshot - B/op 808117 B/op 813586 B/op 0.99
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op 8188 allocs/op 8187 allocs/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot 128515064 ns/op 7226807 B/op 78554 allocs/op 134315109 ns/op 7250191 B/op 78589 allocs/op 0.96
BenchmarkSnapshot/Push_30KB_snapshot - ns/op 128515064 ns/op 134315109 ns/op 0.96
BenchmarkSnapshot/Push_30KB_snapshot - B/op 7226807 B/op 7250191 B/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op 78554 allocs/op 78589 allocs/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot 7058477 ns/op 1138179 B/op 19416 allocs/op 7094386 ns/op 1139095 B/op 19417 allocs/op 0.99
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op 7058477 ns/op 7094386 ns/op 0.99
BenchmarkSnapshot/Pull_3KB_snapshot - B/op 1138179 B/op 1139095 B/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op 19416 allocs/op 19417 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot 17441724 ns/op 9294580 B/op 187553 allocs/op 17461374 ns/op 9301176 B/op 187556 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op 17441724 ns/op 17461374 ns/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - B/op 9294580 B/op 9301176 B/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op 187553 allocs/op 187556 allocs/op 1.00
BenchmarkSplayTree/stress_test_100000 0.1869 ns/op 0 B/op 0 allocs/op 0.2001 ns/op 0 B/op 0 allocs/op 0.93
BenchmarkSplayTree/stress_test_100000 - ns/op 0.1869 ns/op 0.2001 ns/op 0.93
BenchmarkSplayTree/stress_test_100000 - B/op 0 B/op 0 B/op 1
BenchmarkSplayTree/stress_test_100000 - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkSplayTree/stress_test_200000 0.3765 ns/op 0 B/op 0 allocs/op 0.391 ns/op 0 B/op 0 allocs/op 0.96
BenchmarkSplayTree/stress_test_200000 - ns/op 0.3765 ns/op 0.391 ns/op 0.96
BenchmarkSplayTree/stress_test_200000 - B/op 0 B/op 0 B/op 1
BenchmarkSplayTree/stress_test_200000 - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkSplayTree/stress_test_300000 0.595 ns/op 0 B/op 0 allocs/op 0.5963 ns/op 0 B/op 0 allocs/op 1.00
BenchmarkSplayTree/stress_test_300000 - ns/op 0.595 ns/op 0.5963 ns/op 1.00
BenchmarkSplayTree/stress_test_300000 - B/op 0 B/op 0 B/op 1
BenchmarkSplayTree/stress_test_300000 - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkSplayTree/random_access_100000 0.01272 ns/op 0 B/op 0 allocs/op 0.01344 ns/op 0 B/op 0 allocs/op 0.95
BenchmarkSplayTree/random_access_100000 - ns/op 0.01272 ns/op 0.01344 ns/op 0.95
BenchmarkSplayTree/random_access_100000 - B/op 0 B/op 0 B/op 1
BenchmarkSplayTree/random_access_100000 - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkSplayTree/random_access_200000 0.02405 ns/op 0 B/op 0 allocs/op 0.02425 ns/op 0 B/op 0 allocs/op 0.99
BenchmarkSplayTree/random_access_200000 - ns/op 0.02405 ns/op 0.02425 ns/op 0.99
BenchmarkSplayTree/random_access_200000 - B/op 0 B/op 0 B/op 1
BenchmarkSplayTree/random_access_200000 - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkSplayTree/random_access_300000 0.03599 ns/op 0 B/op 0 allocs/op 0.03793 ns/op 0 B/op 0 allocs/op 0.95
BenchmarkSplayTree/random_access_300000 - ns/op 0.03599 ns/op 0.03793 ns/op 0.95
BenchmarkSplayTree/random_access_300000 - B/op 0 B/op 0 B/op 1
BenchmarkSplayTree/random_access_300000 - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkSplayTree/editing_trace_bench 0.002025 ns/op 0 B/op 0 allocs/op 0.002062 ns/op 0 B/op 0 allocs/op 0.98
BenchmarkSplayTree/editing_trace_bench - ns/op 0.002025 ns/op 0.002062 ns/op 0.98
BenchmarkSplayTree/editing_trace_bench - B/op 0 B/op 0 B/op 1
BenchmarkSplayTree/editing_trace_bench - allocs/op 0 allocs/op 0 allocs/op 1
BenchmarkSync/memory_sync_10_test 7975 ns/op 3765 B/op 69 allocs/op 8123 ns/op 3765 B/op 69 allocs/op 0.98
BenchmarkSync/memory_sync_10_test - ns/op 7975 ns/op 8123 ns/op 0.98
BenchmarkSync/memory_sync_10_test - B/op 3765 B/op 3765 B/op 1
BenchmarkSync/memory_sync_10_test - allocs/op 69 allocs/op 69 allocs/op 1
BenchmarkSync/memory_sync_100_test 53003 ns/op 11112 B/op 303 allocs/op 53247 ns/op 11111 B/op 303 allocs/op 1.00
BenchmarkSync/memory_sync_100_test - ns/op 53003 ns/op 53247 ns/op 1.00
BenchmarkSync/memory_sync_100_test - B/op 11112 B/op 11111 B/op 1.00
BenchmarkSync/memory_sync_100_test - allocs/op 303 allocs/op 303 allocs/op 1
BenchmarkSync/memory_sync_1000_test 586828 ns/op 76761 B/op 2145 allocs/op 553195 ns/op 78668 B/op 2265 allocs/op 1.06
BenchmarkSync/memory_sync_1000_test - ns/op 586828 ns/op 553195 ns/op 1.06
BenchmarkSync/memory_sync_1000_test - B/op 76761 B/op 78668 B/op 0.98
BenchmarkSync/memory_sync_1000_test - allocs/op 2145 allocs/op 2265 allocs/op 0.95
BenchmarkSync/memory_sync_10000_test 6449606 ns/op 759169 B/op 21174 allocs/op 7480887 ns/op 737765 B/op 20242 allocs/op 0.86
BenchmarkSync/memory_sync_10000_test - ns/op 6449606 ns/op 7480887 ns/op 0.86
BenchmarkSync/memory_sync_10000_test - B/op 759169 B/op 737765 B/op 1.03
BenchmarkSync/memory_sync_10000_test - allocs/op 21174 allocs/op 20242 allocs/op 1.05
BenchmarkTextEditing 5617443899 ns/op 3982632736 B/op 20647788 allocs/op 4853340799 ns/op 3982622464 B/op 20647736 allocs/op 1.16
BenchmarkTextEditing - ns/op 5617443899 ns/op 4853340799 ns/op 1.16
BenchmarkTextEditing - B/op 3982632736 B/op 3982622464 B/op 1.00
BenchmarkTextEditing - allocs/op 20647788 allocs/op 20647736 allocs/op 1.00
BenchmarkTree/10000_vertices_to_protobuf 3555990 ns/op 6262973 B/op 70025 allocs/op 3527100 ns/op 6262996 B/op 70025 allocs/op 1.01
BenchmarkTree/10000_vertices_to_protobuf - ns/op 3555990 ns/op 3527100 ns/op 1.01
BenchmarkTree/10000_vertices_to_protobuf - B/op 6262973 B/op 6262996 B/op 1.00
BenchmarkTree/10000_vertices_to_protobuf - allocs/op 70025 allocs/op 70025 allocs/op 1
BenchmarkTree/10000_vertices_from_protobuf 158181344 ns/op 442171482 B/op 290039 allocs/op 159944457 ns/op 442173854 B/op 290051 allocs/op 0.99
BenchmarkTree/10000_vertices_from_protobuf - ns/op 158181344 ns/op 159944457 ns/op 0.99
BenchmarkTree/10000_vertices_from_protobuf - B/op 442171482 B/op 442173854 B/op 1.00
BenchmarkTree/10000_vertices_from_protobuf - allocs/op 290039 allocs/op 290051 allocs/op 1.00
BenchmarkTree/20000_vertices_to_protobuf 7825528 ns/op 12716923 B/op 140028 allocs/op 7745215 ns/op 12716921 B/op 140028 allocs/op 1.01
BenchmarkTree/20000_vertices_to_protobuf - ns/op 7825528 ns/op 7745215 ns/op 1.01
BenchmarkTree/20000_vertices_to_protobuf - B/op 12716923 B/op 12716921 B/op 1.00
BenchmarkTree/20000_vertices_to_protobuf - allocs/op 140028 allocs/op 140028 allocs/op 1
BenchmarkTree/20000_vertices_from_protobuf 699853022 ns/op 1697272640 B/op 580090 allocs/op 698654276 ns/op 1697276888 B/op 580091 allocs/op 1.00
BenchmarkTree/20000_vertices_from_protobuf - ns/op 699853022 ns/op 698654276 ns/op 1.00
BenchmarkTree/20000_vertices_from_protobuf - B/op 1697272640 B/op 1697276888 B/op 1.00
BenchmarkTree/20000_vertices_from_protobuf - allocs/op 580090 allocs/op 580091 allocs/op 1.00
BenchmarkTree/30000_vertices_to_protobuf 12208484 ns/op 19318330 B/op 210030 allocs/op 12444412 ns/op 19318248 B/op 210030 allocs/op 0.98
BenchmarkTree/30000_vertices_to_protobuf - ns/op 12208484 ns/op 12444412 ns/op 0.98
BenchmarkTree/30000_vertices_to_protobuf - B/op 19318330 B/op 19318248 B/op 1.00
BenchmarkTree/30000_vertices_to_protobuf - allocs/op 210030 allocs/op 210030 allocs/op 1
BenchmarkTree/30000_vertices_from_protobuf 1654724332 ns/op 3752682784 B/op 870048 allocs/op 1614693599 ns/op 3752052856 B/op 870052 allocs/op 1.02
BenchmarkTree/30000_vertices_from_protobuf - ns/op 1654724332 ns/op 1614693599 ns/op 1.02
BenchmarkTree/30000_vertices_from_protobuf - B/op 3752682784 B/op 3752052856 B/op 1.00
BenchmarkTree/30000_vertices_from_protobuf - allocs/op 870048 allocs/op 870052 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raararaara