Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and invalid link in the yorkie design document #591

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Fix typos and invalid link in the yorkie design document #591

merged 3 commits into from
Jul 30, 2023

Conversation

g2hhh2ee
Copy link
Contributor

@g2hhh2ee g2hhh2ee commented Jul 29, 2023 •
edited
Loading

What this PR does / why we need it:
Fix typos and invalid link in yorkie design document

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 29, 2023 •
edited
Loading

Codecov Report

Merging #591 (d8427de) into main (1b557be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   51.11%   51.11%           
=======================================
  Files          66       66           
  Lines        7008     7008           
=======================================
  Hits         3582     3582           
  Misses       2952     2952           
  Partials      474      474

@se030
Fix typos
f34c75c 
- Data Structures ln47 remove "'"
- Range Deletion in Splay Tree ln28 'avobe' → 'above'
- Range Deletion in Splay Tree ln18 'tree from' → 'tree structure' (more appropriate phrase)
@krapie krapie requested review from hackerwins and krapie July 29, 2023 08:19
@g2hhh2ee g2hhh2ee changed the title Fix typo Fix typos and invalid link in the yorkie design document Jul 29, 2023
krapie
krapie reviewed Jul 29, 2023
View reviewed changes
Copy link
Member

@krapie krapie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 😄

I left a small comment below.

design/data-structure.md Outdated Show resolved Hide resolved
@krapie krapie self-requested a review July 29, 2023 08:52
krapie
krapie approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@krapie krapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

hackerwins
hackerwins approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 036a991 into yorkie-team:main Jul 30, 2023
1 check passed
@krapie krapie requested review from se030 and removed request for se030 August 30, 2023 13:05
Wu22e pushed a commit to Wu22e/yorkie that referenced this pull request Sep 3, 2023
@g2hhh2ee @Wu22e
Fix typos and invalid link in the yorkie design document (yorkie-team…
2883bc3 
…#591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@se030 se030 se030 left review comments

@hackerwins hackerwins hackerwins approved these changes

@krapie krapie krapie approved these changes

Assignees

@g2hhh2ee g2hhh2ee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@g2hhh2ee @CLAassistant @hackerwins @se030 @krapie