-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Broadcast API #631
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
- Coverage 49.47% 48.86% -0.61%
==========================================
Files 69 69
Lines 9951 10082 +131
==========================================
+ Hits 4923 4927 +4
- Misses 4512 4635 +123
- Partials 516 520 +4
☔ View full report in Codecov by Sentry. |
@hackerwins
|
0b261f0
to
8e94207
Compare
8e94207
to
bde74a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
It would be great to refine SubscribeBroadcastEvent
along with integrating the Attach and Watch interfaces(#584).
What this PR does / why we need it:
This pull request introduces the new "broadcast" feature, allowing for the sharing of general events.
Document.broadcast(event)
Which issue(s) this PR fixes:
Address #628
Special notes for your reviewer:
The following are the current implementations that need to be discussed.
I added test cases for the below specs.
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: