Rust 1.80.0 (#2869)

Signed-off-by: utam0k <[email protected]>

crates/libcgroups/src/stats.rs

@@ -183,7 +183,6 @@ pub struct PSIStats {
     pub full: PSIData,
 }
 
-///
 #[derive(Debug, Default, PartialEq, Serialize)]
 pub struct PSIData {
     /// Running average over the last 10 seconds

crates/libcgroups/src/systemd/dbus_native/client.rs

@@ -5,6 +5,7 @@ use super::serialize::Variant;
 use super::utils::SystemdClientError;
 
 pub trait SystemdClient {
+    #[allow(dead_code)]
     fn is_system(&self) -> bool;
 
     fn transient_unit_exists(&self, unit_name: &str) -> bool;

crates/libcgroups/src/systemd/dbus_native/dbus.rs

@@ -23,6 +23,7 @@ const REPLY_BUF_SIZE: usize = 128; // seems good enough tradeoff between extra s
 // For more information see https://www.freedesktop.org/wiki/Software/systemd/dbus/
 pub struct DbusConnection {
     /// Is the socket system level or session specific
+    #[allow(dead_code)]
     system: bool,
     /// socket fd
     socket: i32,

crates/libcgroups/src/v2/memory.rs

@@ -317,15 +317,15 @@ mod tests {
             // check the limit file is set as expected
             let limit_content = read_to_string(tmp.path().join(CGROUP_MEMORY_MAX)).expect("read memory limit to string");
             let limit_check = match linux_memory.limit() {
-                Some(limit) if limit == -1 => limit_content == "max",
+                Some(-1) => limit_content == "max",
                 Some(limit) => limit_content == limit.to_string(),
                 None => limit_content == "0",
             };
 
             // check the swap file is set as expected
             let swap_content = read_to_string(tmp.path().join(CGROUP_MEMORY_SWAP)).expect("read swap limit to string");
             let swap_check = match linux_memory.swap() {
-                Some(swap) if swap == -1 => swap_content == "max",
+                Some(-1)=> swap_content == "max",
                 Some(swap) => {
                     if let Some(limit) = linux_memory.limit() {
                         if limit == -1 {
@@ -339,7 +339,7 @@ mod tests {
                 }
                 None => {
                     match linux_memory.limit() {
-                        Some(limit) if limit == -1 => swap_content == "max",
+                        Some(-1) => swap_content == "max",
                         _ => swap_content == "0",
                     }
                 }
@@ -349,7 +349,7 @@ mod tests {
             // check the reservation file is set as expected
             let reservation_content = read_to_string(tmp.path().join(CGROUP_MEMORY_LOW)).expect("read memory reservation to string");
             let reservation_check = match linux_memory.reservation() {
-                Some(reservation) if reservation == -1 => reservation_content == "max",
+                Some(-1) => reservation_content == "max",
                 Some(reservation) => reservation_content == reservation.to_string(),
                 None => reservation_content == "0",
             };

crates/libcontainer/Cargo.toml

@@ -8,7 +8,7 @@ homepage = "https://containers.github.io/youki"
 readme = "README.md"
 authors = ["youki team"]
 edition = "2021"
-rust-version = "1.58.1"
+rust-version = "1.63.0"
 keywords = ["youki", "container", "cgroups"]
 
 [features]

crates/libcontainer/src/container/state.rs

@@ -11,10 +11,11 @@ use serde::{Deserialize, Serialize};
 use tracing::instrument;
 
 /// Indicates status of the container
-#[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq, Eq)]
+#[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq, Eq, Default)]
 #[serde(rename_all = "camelCase")]
 pub enum ContainerStatus {
     // The container is being created
+    #[default]
     Creating,
     // The runtime has finished the create operation
     Created,
@@ -26,12 +27,6 @@ pub enum ContainerStatus {
     Paused,
 }
 
-impl Default for ContainerStatus {
-    fn default() -> Self {
-        ContainerStatus::Creating
-    }
-}
-
 impl ContainerStatus {
     pub fn can_start(&self) -> bool {
         matches!(self, ContainerStatus::Created)

crates/libcontainer/src/hooks.rs

@@ -56,7 +56,7 @@ pub fn run_hooks(
                 tracing::debug!("run_hooks arg0: {:?}, args: {:?}", arg0, args);
                 hook_command.arg0(arg0).args(args)
             } else {
-                hook_command.arg0(&hook.path().display().to_string())
+                hook_command.arg0(hook.path().display().to_string())
             };
 
             let envs: HashMap<String, String> = if let Some(env) = hook.env() {

crates/libcontainer/src/notify_socket.rs

@@ -181,9 +181,7 @@ mod test {
             move || {
                 // We clone the listener and listen on the cloned listener to
                 // make sure the cloned fd functions correctly.
-                let cloned_listener = listener.clone();
-                cloned_listener.wait_for_container_start().unwrap();
-                cloned_listener.close().unwrap();
+                listener.wait_for_container_start().unwrap();
             }
         });
 

crates/libcontainer/src/rootfs/mount.rs

@@ -56,6 +56,7 @@ type Result<T> = std::result::Result<T, MountError>;
 pub struct MountOptions<'a> {
     pub root: &'a Path,
     pub label: Option<&'a str>,
+    #[allow(dead_code)]
     pub cgroup_ns: bool,
 }
 

crates/youki/Cargo.toml

@@ -57,4 +57,4 @@ scopeguard = "1.2.0"
 
 [build-dependencies]
 anyhow = "1.0.86"
-vergen = { version = "8.3.2", features = ["git", "gitcl"] }
+vergen-gitcl = { version = "1.0.0", features = ["build"] }

crates/youki/build.rs

@@ -1,10 +1,9 @@
 use anyhow::Result;
-use vergen::EmitBuilder;
+use vergen_gitcl::{Emitter, GitclBuilder};
 
-fn main() -> Result<()> {
-    if EmitBuilder::builder()
-        .fail_on_error()
-        .git_sha(true)
+pub fn main() -> Result<()> {
+    if Emitter::default()
+        .add_instructions(&GitclBuilder::all_git()?)?
         .emit()
         .is_err()
     {

crates/youki/src/observability.rs

@@ -49,6 +49,7 @@ pub struct ObservabilityConfig {
     pub log_level: Option<String>,
     pub log_file: Option<PathBuf>,
     pub log_format: Option<String>,
+    #[allow(dead_code)]
     pub systemd_log: bool,
 }
 

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
 profile="default"
-channel="1.77.2"
+channel="1.80.0"

tests/contest/contest/src/tests/mounts_recursive/mod.rs

@@ -609,7 +609,7 @@ fn check_recursive_rsymfollow() -> TestResult {
 /// 1. Create mount_options based on the mount properties of the test
 /// 2. Create OCI.Spec content, container one process is runtimetest,(runtimetest is cargo model, file path `tests/runtimetest/`)
 /// 3. inside container to check if the actual mount matches the spec, (spec https://man7.org/linux/man-pages/man2/mount_setattr.2.html),
-///  eg. tests/runtimetest/src/tests.rs
+///    eg. tests/runtimetest/src/tests.rs
 pub fn get_mounts_recursive_test() -> TestGroup {
     let rro_test = Test::new("rro_test", Box::new(check_recursive_readonly));
     let rnosuid_test = Test::new("rnosuid_test", Box::new(check_recursive_nosuid));