Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: remove unused dependnecies #2921

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented Sep 21, 2024

remove unused deps in youki, found by running cargo machete

question: perhaps we should consider adding this to the CI?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.76%. Comparing base (ea96160) to head (b70efdc).
Report is 14 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2921   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files         131      131           
  Lines       16673    16673           
=======================================
  Hits        11131    11131           
  Misses       5542     5542           

@jprendes jprendes added dependencies Pull requests that update a dependency file kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 21, 2024
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes jprendes removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 21, 2024
@utam0k
Copy link
Member

utam0k commented Sep 23, 2024

question: perhaps we should consider adding this to the CI?

I didn't know that. Exactly. Do you have an intention to contribute?

@utam0k utam0k merged commit da51197 into youki-dev:main Sep 23, 2024
29 of 32 checks passed
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
@Mossaka Mossaka deleted the du-dup branch September 30, 2024 21:05
@Mossaka
Copy link
Contributor Author

Mossaka commented Oct 3, 2024

@utam0k I just realized that my PR removed a pinned version of protobuf. Can you evaluate if that's needed? https://github.com/containers/youki/pull/2921/files#diff-05eb4a3f83693cfbdc185e744c79b31a56b710583017eb128a83fc9dfaf64561L51

@utam0k
Copy link
Member

utam0k commented Oct 7, 2024

@Mossaka I've left my comment on here.
#2497 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants