fix: BadgeProps 타입이 HTMLAttribute 확장하도록 수정 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 그리고 StyledBadge에 나머지 props를 넣어줬어요
Hanna922
reviewed
Nov 17, 2023
| @@ -3,13 +3,14 @@ import { IconContext } from '@/style'; | |||
| import { StyledBadge } from './Badge.style'; | |||
| import { BadgeProps } from './Badge.type'; | |||
|
|
|||
| const Badge = ({ color = 'monoItemBG', children = 'Badge', leftIcon }: BadgeProps) => { | |||
| const Badge = ({ color = 'monoItemBG', children = 'Badge', leftIcon, ...props }: BadgeProps) => { | |||
There was a problem hiding this comment.
혹시 Badge에서 forwardRef를 사용하지 않는 이유가 있나용??
There was a problem hiding this comment.
-
Badge는 사용자랑 상호작용하지 않고, 상태가 1개인 단순 정보 표기용 컴포넌트임
➡ 부모 컴포넌트에서Badge의 상태나 값 같은 내부 요소에 접근할 일이 없을거라고 생각함 -
YDS-React-old에서도 사용하지 않았음
위와 같은 이유로,, forwardRef를 사용하지 않았습니다!
혹시 사용해야 한다고 생각해서 코멘트 준거였나영?! (╯▽╰ )
There was a problem hiding this comment.
아뇨! 달아주신 코멘트 내용이 궁금해서 여쭤봤숩니당 ㅎㅅㅎ
Hanna922
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
BadgeProps가React.HTMLAttributes<HTMLDivElement>를 확장하도록 수정했어요왜 안했을가요4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?