fix: icons -> iconsAsset 폴더명 변경 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- src/style/foundation/icons와 icons 폴더명 중복을 해소
|
|
Hanna922
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
버그 픽스
icons: 아이콘 svg 파일, convert.mjs가 들어있는 폴더 (배포 ❌)src/style/foundation/icons: 실제 사용하는 Icon.tsx가 들어있는 폴더 (배포 ⭕).npmignore파일 내용 중icons로 인해 후자가 배포될 때 누락되는 에러가 있어서 폴더명이 겹치지 않게 수정했습니다2️⃣ 알아두시면 좋아요!
전자랑 후자 중에 어느 쪽의 이름을 바꿀지 고민했는데요?!?!
foundation/icons가 나을 거 같아서 전자를 바꿨습니다3️⃣ 추후 작업
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?