feat: create PasswordTextField #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanna922
changed the title
nijuy
changed the title
nijuy
reviewed
Apr 27, 2024
There was a problem hiding this comment.
The password input type in Microsoft Edge includes a password reveal button. - https://learn.microsoft.com/ko-kr/microsoft-edge/web-platform/password-reveal
엣지는 기본 reveal-icon이 있어서 눈알이 두 개 보이고 있어요 👁👁
점유율만 보면 크롬이 압도적이긴 한데 아예 안 쓰는 브라우저는 아니라서 커버하는 게 좋을 거 같습니다
➡ 관련 코드 추가해서 바로 커밋해뒀습니다 말없이 커밋한점 송죄송죄 5e46b05
There was a problem hiding this comment.
감사합니다 세심허네요......👍
이 수정사항은 저한테 전달해서 #73 에 넣는 게 브랜치 목적을 생각했을 때 더 적절했을 거 같네요!!
만약 SimpleTextField 수정 계획이 없었다면 여기 넣어도 무방하나 그게 아닌 상황이니가요
- 엣지에서 password type input에 기본적으로 포함하는 버튼
nijuy
approved these changes
Apr 27, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?