refactor: OnlyBGColor 조건 수정
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
OnlyBGColor조건 수정 #86기존 코드에 영향을 미치는 변경사항
OnlyBGColor의 범위를이름에 'ItemBG'가 포함되는 타입으로 수정했습니다관련 타입 이름에
Item을 추가했습니다2️⃣ 알아두시면 좋아요!
컴포넌트 하나만 고려해서 타입을 수정하는 게 문제가 될 수도 있을 거 같아서
나중에
BG가 들어간 타입만 쓰게 될 수도 있을지 생각해봤는데,토스트/툴팁/버튼용 컬러를 한 곳에서 사용할 일이 없을 거라고 생각해서 이렇게 수정해봤습니다
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?