-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YDS-206] TopBar & TopBarButton 구현 #211
Conversation
* YdsBaseButton minSize 선택적으로 변경 * DoubleTitleTopBar 명세에 맞게 변경 * SearchedTextField 구현
compose/src/main/java/com/yourssu/design/system/compose/atom/SearchTextField.kt
Outdated
Show resolved
Hide resolved
onValueChange = { | ||
text = it | ||
}, | ||
onX = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear action을 외부에서 넣어줘야 하는지는 고민해볼 필요가 있을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 👍
나머지 코멘트 없는 부분도 modifier 파라미터 추가해주시면 감사하겠습니다
compose/src/main/java/com/yourssu/design/system/compose/base/YdsBaseButton.kt
Outdated
Show resolved
Hide resolved
compose/src/main/java/com/yourssu/design/system/compose/base/YdsBaseButton.kt
Outdated
Show resolved
Hide resolved
compose/src/main/java/com/yourssu/design/system/compose/components/DoubleTitleTopBar.kt
Outdated
Show resolved
Hide resolved
compose/src/main/java/com/yourssu/design/system/compose/base/YdsBaseButton.kt
Outdated
Show resolved
Hide resolved
compose/src/main/java/com/yourssu/design/system/compose/atom/SearchTextField.kt
Outdated
Show resolved
Hide resolved
- YdsBaseButton defaultMinSize 변경 완료 - modifier들 끌어올리기
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~!
덕분에 이제 YDS로 수월하게 작업할 수 있겠네요 👍
Summary
Describe your changes
TopBar
SingleTitleTopBar
DoubleTitleTopBar
SearchTopBar
Issue