[YDS-206] TopBar & TopBarButton 구현 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* YdsBaseButton minSize 선택적으로 변경 * DoubleTitleTopBar 명세에 맞게 변경 * SearchedTextField 구현
coding-polarbear
previously approved these changes
Nov 8, 2023
compose/src/main/java/com/yourssu/design/system/compose/atom/SearchTextField.kt
Outdated
Show resolved
Hide resolved
| onValueChange = { | ||
| text = it | ||
| }, | ||
| onX = { |
There was a problem hiding this comment.
Clear action을 외부에서 넣어줘야 하는지는 고민해볼 필요가 있을 것 같아요
cometj03
reviewed
Nov 8, 2023
compose/src/main/java/com/yourssu/design/system/compose/base/YdsBaseButton.kt
Outdated
Show resolved
Hide resolved
compose/src/main/java/com/yourssu/design/system/compose/base/YdsBaseButton.kt
Outdated
Show resolved
Hide resolved
compose/src/main/java/com/yourssu/design/system/compose/components/DoubleTitleTopBar.kt
Outdated
Show resolved
Hide resolved
cometj03
reviewed
Nov 8, 2023
compose/src/main/java/com/yourssu/design/system/compose/base/YdsBaseButton.kt
Outdated
Show resolved
Hide resolved
compose/src/main/java/com/yourssu/design/system/compose/atom/SearchTextField.kt
Outdated
Show resolved
Hide resolved
- YdsBaseButton defaultMinSize 변경 완료 - modifier들 끌어올리기
cometj03
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes
TopBar
SingleTitleTopBar
DoubleTitleTopBar
SearchTopBar
Issue