Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YDS-#245] Hotfix : jdk11 -> jdk17 #252

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

Gael-Android
Copy link
Contributor

Summary

Yds 2.5.2 버전부터 jitpack에 빌드오류발생

An exception occurred applying plugin request [id: 'com.android.library']

Failed to apply plugin 'com.android.internal.library'.
Android Gradle plugin requires Java 17 to run. You are currently using Java 11.

Describe your changes

그래서 jitpack.yml에 openjdk 버전을 11 -> 17로 업데이트

Issue

#245

To reviewers

@Gael-Android Gael-Android added bug Something isn't working help wanted Extra attention is needed labels Feb 6, 2024
@Gael-Android Gael-Android self-assigned this Feb 6, 2024
@Gael-Android Gael-Android changed the title hotfix : jdk11 -> jdk17 [Yds-#245] Hotfix : jdk11 -> jdk17 Feb 6, 2024
@Gael-Android Gael-Android changed the title [Yds-#245] Hotfix : jdk11 -> jdk17 [YDS-#245] Hotfix : jdk11 -> jdk17 Feb 6, 2024
@cometj03
Copy link
Member

cometj03 commented Feb 7, 2024

아마 compose 모듈의 자바 버전도 올려줘야 할 것 같아요
버전 업데이트도 해주시면 감사하겠습니다

@cometj03
Copy link
Member

cometj03 commented Feb 7, 2024

버전도 올려주셔야 합니다.

@Gael-Android
Copy link
Contributor Author

어떻게 올릴까요?

@Gael-Android
Copy link
Contributor Author

이건 바로 머지할까요?

@cometj03
Copy link
Member

cometj03 commented Feb 7, 2024

이건 바로 머지할까요?

@Gael-Android Gael-Android merged commit 04909bd into develop Feb 7, 2024
1 check passed
@Gael-Android Gael-Android deleted the hotfix/gael/jitpack-build-fail branch February 7, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants