feat: 과목 생성 api 구현 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/com/yourssu/soongpt/domain/course/application/CourseController.kt # src/main/kotlin/com/yourssu/soongpt/domain/course/business/CourseService.kt # src/main/kotlin/com/yourssu/soongpt/domain/course/implement/CourseWriter.kt
DWL21
requested changes
Feb 5, 2025
src/main/kotlin/com/yourssu/soongpt/domain/course/application/CourseController.kt
Show resolved
Hide resolved
Comment on lines
+21
to
+27
| val classification = when (classificationStr) { | ||
| "전필", "전기" -> Classification.MAJOR_REQUIRED | ||
| "전선" -> Classification.MAJOR_ELECTIVE | ||
| "교필" -> Classification.GENERAL_REQUIRED | ||
| "교선" -> Classification.GENERAL_ELECTIVE | ||
| "채플" -> Classification.CHAPEL | ||
| else -> continue |
There was a problem hiding this comment.
Classification 클래스에서 companion object로 valueOf 정의해서 구현하는건 어떨까요?
Comment on lines
+159
to
+170
| private fun parseWeek(day: String): Week { | ||
| return when(day) { | ||
| "월" -> Week.MONDAY | ||
| "화" -> Week.TUESDAY | ||
| "수" -> Week.WEDNESDAY | ||
| "목" -> Week.THURSDAY | ||
| "금" -> Week.FRIDAY | ||
| "토" -> Week.SATURDAY | ||
| "일" -> Week.SUNDAY | ||
| else -> throw IllegalArgumentException("알 수 없는 요일 : $day") | ||
| } | ||
| } |
| connectTimeout: 5000 | ||
| loggerLevel: full | ||
| defaultRequestHeaders: | ||
| Authorization: Bearer accessToken |
There was a problem hiding this comment.
슬랙 엑세스 토큰을 넣어야해서 환경변수로 만들어주세요.
DWL21
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes
To Reviewers