Skip to content

Commit

Permalink
Address comments.
Browse files Browse the repository at this point in the history
Change-Id: Ide8f7df2ad335224a90318b1c6fd1fa7ad19742d
  • Loading branch information
yjzhang111 committed Aug 8, 2024
1 parent b4688dc commit 064c929
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
6 changes: 0 additions & 6 deletions starboard/common/file.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,6 @@

namespace starboard {

struct FileStruct {
int fd;
};

typedef FileStruct* FilePtr;

bool FileCanOpen(const char* path, int flags);

bool IsValid(int file);
Expand Down
2 changes: 1 addition & 1 deletion starboard/common/file_wrapper.cc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2016 The Cobalt Authors. All Rights Reserved.
// Copyright 2024 The Cobalt Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion third_party/musl/src/starboard/sys/stat.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ int stat(const char *path, struct stat *file_info)
}

// In SB_API_VERSION < 16, all files are opened with S_IRUSR | S_IWUSR.
// See http://shortn/_UxFowRzNXq.
// See starboard/shared/posix/impl/file_open.h.
file_info->st_mode = S_IRUSR | S_IWUSR;
if (out_info.is_directory){
file_info->st_mode |= S_IFDIR;
Expand Down

0 comments on commit 064c929

Please sign in to comment.