Skip to content

Commit

Permalink
[media] Remove //third_party/ffmpeg from build (#4425)
Browse files Browse the repository at this point in the history
Sets the media GN arg `media_use_ffmpeg` to false for Chrobalt builds.
This removes the //third_party/ffmpeg target from media.

b/378909148
  • Loading branch information
osagie98 authored Nov 13, 2024
1 parent b627190 commit 248d236
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions media/media_options.gni
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ declare_args() {
media_use_libvpx = false
}

# Chrobalt doesn't use ffmpeg.
if (is_cobalt) {
media_use_ffmpeg = false
}

# Enable usage of OpenH264 within the media library. Used for software based
# encoding of H264 content.
media_use_openh264 = true
Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/renderer/platform/media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ component("media") {
"//third_party/blink/renderer/platform:allow_discouraged_type",
]

if (media_use_ffmpeg || !is_android) {
if (media_use_ffmpeg || !is_android || is_cobalt) {
sources += [
"buffered_data_source_host_impl.cc",
"buffered_data_source_host_impl.h",
Expand Down

0 comments on commit 248d236

Please sign in to comment.