Skip to content

Commit

Permalink
Add nplb sources to fix include check on android (#4638)
Browse files Browse the repository at this point in the history
These sources were removed from nplb for android platforms during the
migration of nplb from older branches. I couldn't find a reason for
their removal, and adding them back resolves a gn include check.

b/377295011
  • Loading branch information
hlwarriner authored Jan 6, 2025
1 parent 5a10f25 commit 387b23b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions starboard/nplb/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ test("nplb") {
"//starboard/nplb/sabi/struct_alignment_test.cc",
"//starboard/shared/starboard/drm/drm_test_helpers.cc",
"//starboard/shared/starboard/drm/drm_test_helpers.h",
"//starboard/testing/fake_graphics_context_provider.cc",
"//starboard/testing/fake_graphics_context_provider.h",
"align_test.cc",
"audio_sink_create_test.cc",
"audio_sink_destroy_test.cc",
Expand Down Expand Up @@ -219,8 +221,6 @@ test("nplb") {

if (!is_android) {
sources += [
"//starboard/testing/fake_graphics_context_provider.cc",
"//starboard/testing/fake_graphics_context_provider.h",
"maximum_player_configuration_explorer_test.cc",
"media_set_audio_write_duration_test.cc",
"multiple_player_test.cc",
Expand Down
3 changes: 1 addition & 2 deletions starboard/nplb/maximum_player_configuration_explorer.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
#include "starboard/nplb/player_test_util.h"
#include "starboard/player.h"
#include "starboard/shared/starboard/media/media_util.h"
// TODO(cobalt, b/377295011): remove the nogncheck annotation.
#include "starboard/testing/fake_graphics_context_provider.h" // nogncheck
#include "starboard/testing/fake_graphics_context_provider.h"

namespace starboard {
namespace nplb {
Expand Down

0 comments on commit 387b23b

Please sign in to comment.