Move cobalt/fonts to starboard/fonts (#3754)

Removes reverse dependencies from Starboard back to Cobalt. No targets
within Starboard should refer to anything in /cobalt toplevel directory.

Test-On-Device: true

b/262794004

.pre-commit-config.yaml

@@ -145,6 +145,7 @@ repos:
                 content/|
                 internal/starboard/shared/glimp/|
                 nb/|
+                starboard/content/fonts/LICENSES.txt |
                 starboard/android/apk/gradlew|
                 starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaDrmBridge.java$|
                 starboard/shared/starboard/player/filter/decoded_audio_queue.cc$|

cobalt/browser/BUILD.gn

@@ -60,11 +60,11 @@ target(final_executable_type, "cobalt") {
   ]
   data_deps = [ "//cobalt/network:copy_ssl_certificates" ]
   if (cobalt_font_package == "empty") {
-    data_deps += [ "//cobalt/content/fonts:copy_font_data" ]
+    data_deps += [ "//starboard/content/fonts:copy_font_data" ]
   } else {
     data_deps += [
-      "//cobalt/content/fonts:copy_fonts",
-      "//cobalt/content/fonts:fonts_xml",
+      "//starboard/content/fonts:copy_fonts",
+      "//starboard/content/fonts:fonts_xml",
     ]
   }
   if (sb_is_evergreen) {

cobalt/layout_tests/BUILD.gn

@@ -69,11 +69,11 @@ target(gtest_target_type, "layout_tests") {
     "//cobalt/network:copy_ssl_certificates",
   ]
   if (cobalt_font_package == "empty") {
-    data_deps += [ "//cobalt/content/fonts:copy_font_data" ]
+    data_deps += [ "//starboard/content/fonts:copy_font_data" ]
   } else {
     data_deps += [
-      "//cobalt/content/fonts:copy_fonts",
-      "//cobalt/content/fonts:fonts_xml",
+      "//starboard/content/fonts:copy_fonts",
+      "//starboard/content/fonts:fonts_xml",
     ]
   }
 }

cobalt/renderer/BUILD.gn

@@ -52,7 +52,6 @@ static_library("renderer") {
     "//cobalt/base",
     "//cobalt/browser/memory_settings:browser_memory_settings",
     "//cobalt/configuration",
-    "//cobalt/content/fonts:copy_font_data",
     "//cobalt/math",
     "//cobalt/render_tree",
     "//cobalt/render_tree:animations",
@@ -64,6 +63,7 @@ static_library("renderer") {
     "//cobalt/system_window",
     "//cobalt/watchdog",
     "//starboard:starboard_headers_only",
+    "//starboard/content/fonts:copy_font_data",
   ]
 
   if (is_starboard) {
@@ -141,11 +141,11 @@ target(gtest_target_type, "renderer_test") {
   ]
 
   if (cobalt_font_package == "empty") {
-    data_deps += [ "//cobalt/content/fonts:copy_font_data" ]
+    data_deps += [ "//starboard/content/fonts:copy_font_data" ]
   } else {
     data_deps += [
-      "//cobalt/content/fonts:copy_fonts",
-      "//cobalt/content/fonts:fonts_xml",
+      "//starboard/content/fonts:copy_fonts",
+      "//starboard/content/fonts:fonts_xml",
     ]
   }
 }

starboard/build/config/BUILDCONFIG.gn

@@ -359,11 +359,11 @@ template("evergreen_loader") {
     "//starboard/loader_app:copy_loader_app_content",
   ]
   if (cobalt_font_package == "empty") {
-    shared_data_deps += [ "//cobalt/content/fonts:copy_font_data" ]
+    shared_data_deps += [ "//starboard/content/fonts:copy_font_data" ]
   } else {
     shared_data_deps += [
-      "//cobalt/content/fonts:copy_fonts",
-      "//cobalt/content/fonts:fonts_xml",
+      "//starboard/content/fonts:copy_fonts",
+      "//starboard/content/fonts:fonts_xml",
     ]
   }
   shared_library(target_name) {
@@ -382,8 +382,8 @@ template("evergreen_loader") {
 
     deps = [
       ":copy_loader_app_lib${original_target_name}",
-      "//cobalt/content/fonts:copy_font_data",
       "//starboard:starboard_group",
+      "//starboard/content/fonts:copy_font_data",
       "//starboard/elf_loader:constants",
       "//starboard/elf_loader:elf_loader",
       "//starboard/elf_loader:evergreen_info",

starboard/build/config/base_configuration.gni

@@ -12,9 +12,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import("//cobalt/content/fonts/font_configuration.gni")
 import("//starboard/build/config/clang.gni")
 import("//starboard/build/config/enable_vr.gni")
+import("//starboard/content/fonts/font_configuration.gni")
 
 # NOTE:
 # All build arguments in this file must have documentation.

cobalt/content/fonts/BUILD.gn → starboard/content/fonts/BUILD.gn

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import("//cobalt/content/fonts/variables.gni")
+import("//starboard/content/fonts/variables.gni")
 
 if (cobalt_font_package == "empty") {
   copy("copy_font_data") {

cobalt/content/fonts/config/android/fonts.xml → starboard/content/fonts/config/android/fonts.xml

@@ -1,4 +1,6 @@
 <!--
+ | Copyright 2024 The Cobalt Authors. All Rights Reserved.
+ |
  |==============================================================================
  | OVERVIEW
  | The font configuration files specify the local fonts available to Cobalt.

cobalt/content/fonts/config/common/fonts.xml → starboard/content/fonts/config/common/fonts.xml

@@ -1,4 +1,6 @@
 <!--
+ | Copyright 2024 The Cobalt Authors. All Rights Reserved.
+ |
  |==============================================================================
  | OVERVIEW
  | The font configuration files specify the local fonts available to Cobalt.

cobalt/content/fonts/scripts/README.md → starboard/content/fonts/scripts/README.md

@@ -7,6 +7,6 @@ Instructions for generating a minimal subset of 'Roboto-Regular.ttf for devices
 with limited space:
 
   1.  Download `fontforge` using apt. `sudo apt install python-fontforge`
-  2.  `cd src/cobalt/content/fonts/scripts`
+  2.  `cd src/starboard/content/fonts/scripts`
   3.  `python generate_roboto_regular_subsetted.py`
-  4.  Move 'Roboto-Regular-Subsetted.ttf' into 'cobalt/content/fonts/all_fonts'
+  4.  Move 'Roboto-Regular-Subsetted.ttf' into 'starboard/content/fonts/all_fonts'

cobalt/content/fonts/scripts/filter_fonts.py → starboard/content/fonts/scripts/filter_fonts.py

@@ -38,7 +38,7 @@ def SelectFont(font_node, package_categories):
   Args:
     font_node: The <font> node to evaluate.
     package_categories: Dictionary of package name to category number.
-      The category values are described in cobalt/content/fonts/README.md
+      The category values are described in starboard/content/fonts/README.md
   Returns:
     True to keep this font, False to delete it.
   """

starboard/content/fonts/scripts/generate_roboto_regular_subsetted.py

@@ -0,0 +1,39 @@
+#!/usr/bin/python2
+# Copyright 2024 The Cobalt Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+"""Generates a minimal subset of the characters from Roboto-Regular."""
+
+import fontforge
+
+
+def main():
+  font = fontforge.open("Roboto-Regular.ttf")
+
+  # Add the .notdef glyph
+  font.selection.select(".notdef")
+  # Add Basic Latin
+  font.selection.select(("more", "ranges"), 0, 127)
+  # Add No-Break Space
+  font.selection.select(("more", "unicode"), 160)
+
+  # Clear out everything from the font but the selections.
+  font.selection.invert()
+  font.clear()
+
+  font.generate("Roboto-Regular-Subsetted.ttf")
+
+
+if __name__ == "__main__":
+  main()

starboard/doc/evergreen/cobalt_evergreen_overview.md

@@ -548,7 +548,7 @@ On Raspberry Pi the Cobalt fonts are configured the following way:
 
 `empty` set of fonts under:
 ```
-<kSbSystemPathContentDirectory>/app/cobalt/content/fonts
+<kSbSystemPathContentDirectory>/app/starboard/content/fonts
 ```
 
 `standard` or `limited` set of fonts under:

starboard/elf_loader/BUILD.gn

@@ -94,11 +94,11 @@ if (sb_is_evergreen_compatible && current_toolchain == starboard_toolchain) {
 if (current_toolchain == starboard_toolchain && host_os != "win") {
   target(starboard_level_final_executable_type, "elf_loader_sandbox") {
     if (cobalt_font_package == "empty") {
-      data_deps = [ "//cobalt/content/fonts:copy_font_data" ]
+      data_deps = [ "//starboard/content/fonts:copy_font_data" ]
     } else {
       data_deps = [
-        "//cobalt/content/fonts:copy_fonts",
-        "//cobalt/content/fonts:fonts_xml",
+        "//starboard/content/fonts:copy_fonts",
+        "//starboard/content/fonts:fonts_xml",
       ]
     }
 
@@ -110,8 +110,8 @@ if (current_toolchain == starboard_toolchain && host_os != "win") {
       ":elf_loader",
       ":evergreen_info",
       ":sabi_string",
-      "//cobalt/content/fonts:copy_font_data",
       "//starboard:starboard_group",
+      "//starboard/content/fonts:copy_font_data",
     ]
 
     if (!sb_is_evergreen_compatible) {

starboard/loader_app/BUILD.gn

@@ -91,18 +91,18 @@ if (sb_is_evergreen_compatible && current_toolchain == starboard_toolchain) {
     build_loader = false
     if (target_cpu == "x64" || target_cpu == "arm" || target_cpu == "arm64") {
       if (cobalt_font_package == "empty") {
-        data_deps = [ "//cobalt/content/fonts:copy_font_data" ]
+        data_deps = [ "//starboard/content/fonts:copy_font_data" ]
       } else {
         data_deps = [
-          "//cobalt/content/fonts:copy_fonts",
-          "//cobalt/content/fonts:fonts_xml",
+          "//starboard/content/fonts:copy_fonts",
+          "//starboard/content/fonts:fonts_xml",
         ]
       }
       sources = _common_loader_app_sources
       deps = [
         ":common_loader_app_dependencies",
-        "//cobalt/content/fonts:copy_font_data",
         "//starboard:starboard_with_main",
+        "//starboard/content/fonts:copy_font_data",
         "//starboard/elf_loader",
       ]
       if (sb_is_evergreen_compatible && sb_evergreen_compatible_package) {
@@ -140,7 +140,7 @@ if (sb_is_evergreen_compatible && current_toolchain == starboard_toolchain) {
       ]
       deps = [
         ":common_loader_app_dependencies",
-        "//cobalt/content/fonts:copy_font_data",
+        "//starboard/content/fonts:copy_font_data",
         "//starboard/elf_loader:elf_loader_sys",
       ]
     }