Remove SbSocketSetFoo APIs

Change-Id: I7592d5592d3cbbbe788263b31aaa92ec6f756d88

starboard/android/shared/BUILD.gn

@@ -100,12 +100,7 @@ static_library("starboard_platform") {
     "//starboard/shared/posix/socket_receive_from.cc",
     "//starboard/shared/posix/socket_send_to.cc",
     "//starboard/shared/posix/socket_set_broadcast.cc",
-    "//starboard/shared/posix/socket_set_receive_buffer_size.cc",
     "//starboard/shared/posix/socket_set_reuse_address.cc",
-    "//starboard/shared/posix/socket_set_send_buffer_size.cc",
-    "//starboard/shared/posix/socket_set_tcp_keep_alive.cc",
-    "//starboard/shared/posix/socket_set_tcp_no_delay.cc",
-    "//starboard/shared/posix/socket_set_tcp_window_scaling.cc",
     "//starboard/shared/posix/storage_write_record.cc",
     "//starboard/shared/posix/system_break_into_debugger.cc",
     "//starboard/shared/posix/system_clear_last_error.cc",

starboard/common/socket.cc

@@ -128,26 +128,6 @@ bool Socket::SetReuseAddress(bool value) {
   return SbSocketSetReuseAddress(socket_, value);
 }
 
-bool Socket::SetReceiveBufferSize(int32_t size) {
-  return SbSocketSetReceiveBufferSize(socket_, size);
-}
-
-bool Socket::SetSendBufferSize(int32_t size) {
-  return SbSocketSetSendBufferSize(socket_, size);
-}
-
-bool Socket::SetTcpKeepAlive(bool value, int64_t period) {
-  return SbSocketSetTcpKeepAlive(socket_, value, period);
-}
-
-bool Socket::SetTcpNoDelay(bool value) {
-  return SbSocketSetTcpNoDelay(socket_, value);
-}
-
-bool Socket::SetTcpWindowScaling(bool value) {
-  return SbSocketSetTcpWindowScaling(socket_, value);
-}
-
 SbSocket Socket::socket() {
   return socket_;
 }

starboard/elf_loader/exported_symbols.cc

@@ -161,12 +161,7 @@ ExportedSymbols::ExportedSymbols() {
   REGISTER_SYMBOL(SbSocketReceiveFrom);
   REGISTER_SYMBOL(SbSocketSendTo);
   REGISTER_SYMBOL(SbSocketSetBroadcast);
-  REGISTER_SYMBOL(SbSocketSetReceiveBufferSize);
   REGISTER_SYMBOL(SbSocketSetReuseAddress);
-  REGISTER_SYMBOL(SbSocketSetSendBufferSize);
-  REGISTER_SYMBOL(SbSocketSetTcpKeepAlive);
-  REGISTER_SYMBOL(SbSocketSetTcpNoDelay);
-  REGISTER_SYMBOL(SbSocketSetTcpWindowScaling);
   REGISTER_SYMBOL(SbSocketWaiterAdd);
   REGISTER_SYMBOL(SbSocketWaiterCreate);
   REGISTER_SYMBOL(SbSocketWaiterDestroy);

starboard/linux/shared/BUILD.gn

@@ -170,12 +170,7 @@ static_library("starboard_platform_sources") {
     "//starboard/shared/posix/socket_receive_from.cc",
     "//starboard/shared/posix/socket_send_to.cc",
     "//starboard/shared/posix/socket_set_broadcast.cc",
-    "//starboard/shared/posix/socket_set_receive_buffer_size.cc",
     "//starboard/shared/posix/socket_set_reuse_address.cc",
-    "//starboard/shared/posix/socket_set_send_buffer_size.cc",
-    "//starboard/shared/posix/socket_set_tcp_keep_alive.cc",
-    "//starboard/shared/posix/socket_set_tcp_no_delay.cc",
-    "//starboard/shared/posix/socket_set_tcp_window_scaling.cc",
     "//starboard/shared/posix/storage_write_record.cc",
     "//starboard/shared/posix/system_break_into_debugger.cc",
     "//starboard/shared/posix/system_clear_last_error.cc",

starboard/raspi/shared/BUILD.gn

@@ -128,12 +128,7 @@ static_library("starboard_platform_sources") {
     "//starboard/shared/posix/socket_receive_from.cc",
     "//starboard/shared/posix/socket_send_to.cc",
     "//starboard/shared/posix/socket_set_broadcast.cc",
-    "//starboard/shared/posix/socket_set_receive_buffer_size.cc",
     "//starboard/shared/posix/socket_set_reuse_address.cc",
-    "//starboard/shared/posix/socket_set_send_buffer_size.cc",
-    "//starboard/shared/posix/socket_set_tcp_keep_alive.cc",
-    "//starboard/shared/posix/socket_set_tcp_no_delay.cc",
-    "//starboard/shared/posix/socket_set_tcp_window_scaling.cc",
     "//starboard/shared/posix/storage_write_record.cc",
     "//starboard/shared/posix/system_break_into_debugger.cc",
     "//starboard/shared/posix/system_clear_last_error.cc",

starboard/socket.h

@@ -352,63 +352,6 @@ SB_EXPORT bool SbSocketSetBroadcast(SbSocket socket, bool value);
 // |value|: The new value for the option.
 SB_EXPORT bool SbSocketSetReuseAddress(SbSocket socket, bool value);
 
-// DEPRECATED with SB_API_VERSION 16
-//
-// Sets the |SO_RCVBUF|, or equivalent, option to |size| on |socket|. The
-// return value indicates whether the option was actually set.
-//
-// |socket|: The SbSocket for which the option is set.
-// |size|: The value for the option.
-SB_EXPORT bool SbSocketSetReceiveBufferSize(SbSocket socket, int32_t size);
-
-// DEPRECATED with SB_API_VERSION 16
-//
-// Sets the |SO_SNDBUF|, or equivalent, option to |size| on |socket|. The
-// return value indicates whether the option was actually set.
-//
-// |socket|: The SbSocket for which the option is set.
-// |size|: The value for the option.
-SB_EXPORT bool SbSocketSetSendBufferSize(SbSocket socket, int32_t size);
-
-// DEPRECATED with SB_API_VERSION 16
-//
-// Sets the |SO_KEEPALIVE|, or equivalent, option to |value| on |socket|. The
-// return value indicates whether the option was actually set.
-//
-// |socket|: The SbSocket for which the option is set.
-// |value|: If set to |true|, then |period| specifies the minimum time in
-//   microseconds between keep-alive packets. If set to |false|, |period|
-//   is ignored.
-// |period|: The time in microseconds between keep-alive packets. This value
-//   is only relevant if |value| is |true|.
-SB_EXPORT bool SbSocketSetTcpKeepAlive(SbSocket socket,
-                                       bool value,
-                                       int64_t period);
-
-// DEPRECATED with SB_API_VERSION 16
-//
-// Sets the |TCP_NODELAY|, or equivalent, option to |value| on |socket|. The
-// return value indicates whether the option was actually set.
-//
-// This function disables the Nagle algorithm for reducing the number of
-// packets sent when converting from a stream to packets. Disabling Nagle
-// generally puts the data for each Send call into its own packet, but does
-// not guarantee that behavior.
-//
-// |socket|: The SbSocket for which the option is set.
-// |value|: Indicates whether the Nagle algorithm should be disabled
-//   (|value|=|true|).
-SB_EXPORT bool SbSocketSetTcpNoDelay(SbSocket socket, bool value);
-
-// DEPRECATED with SB_API_VERSION 16
-//
-// Sets the |SO_WINSCALE|, or equivalent, option to |value| on |socket|. The
-// return value indicates whether the option was actually set.
-//
-// |socket|: The SbSocket for which the option is set.
-// |value|: The value for the option.
-SB_EXPORT bool SbSocketSetTcpWindowScaling(SbSocket socket, bool value);
-
 #ifdef __cplusplus
 }  // extern "C"
 #endif

starboard/stub/BUILD.gn

@@ -115,12 +115,7 @@ static_library("stub_sources") {
     "//starboard/shared/stub/socket_receive_from.cc",
     "//starboard/shared/stub/socket_send_to.cc",
     "//starboard/shared/stub/socket_set_broadcast.cc",
-    "//starboard/shared/stub/socket_set_receive_buffer_size.cc",
     "//starboard/shared/stub/socket_set_reuse_address.cc",
-    "//starboard/shared/stub/socket_set_send_buffer_size.cc",
-    "//starboard/shared/stub/socket_set_tcp_keep_alive.cc",
-    "//starboard/shared/stub/socket_set_tcp_no_delay.cc",
-    "//starboard/shared/stub/socket_set_tcp_window_scaling.cc",
     "//starboard/shared/stub/socket_waiter_add.cc",
     "//starboard/shared/stub/socket_waiter_create.cc",
     "//starboard/shared/stub/socket_waiter_destroy.cc",