Ensure that MP3, FLAC, and PCM are not supported for MediaSource. #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
=======================================
Coverage 57.77% 57.78%
=======================================
Files 1915 1915
Lines 95118 95123 +5
=======================================
+ Hits 54956 54963 +7
+ Misses 40162 40160 -2 ☔ View full report in Codecov by Sentry. |
This change makes the logic of CanPlayAdaptive more like CanPlayProgressive, wherein unsupported containers are immediately filtered out. Bug: b/297060983 Test: Added unit tests. Also manually ran Cobalt and verified that MediaSource.isTypeSupported returns false for these MIME strings: 'audio/mpeg; codecs="mp3"' 'audio/mpeg' 'audio/ogg; codecs="flac"' 'audio/flac; codecs="flac"' 'audio/wav; codecs="1"'
Bug: b/297060983
Bug: b/297060983
antoniori-eng
force-pushed
the
isTypeSupported_fix
branch
from
c7f3795 to
9cc6235
Compare
jasonzhangxx
approved these changes
Nov 16, 2023
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
…utube#1359) This change makes the logic of CanPlayAdaptive more like CanPlayProgressive, wherein unsupported containers are immediately filtered out. Bug: b/297060983 Test: Added unit tests. Also manually ran Cobalt and verified that MediaSource.isTypeSupported returns false for these MIME strings: 'audio/mpeg; codecs="mp3"' 'audio/mpeg' 'audio/ogg; codecs="flac"' 'audio/flac; codecs="flac"' 'audio/wav; codecs="1"'
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
…rce." (youtube#2005) Reverts youtube#1359 b/297060983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the logic of CanPlayAdaptive more like CanPlayProgressive, wherein unsupported containers are immediately filtered out.
Bug: b/297060983
Test: Added unit tests. Also manually ran Cobalt and verified that MediaSource.isTypeSupported returns false for these MIME strings: 'audio/mpeg; codecs="mp3"'
'audio/mpeg'
'audio/ogg; codecs="flac"'
'audio/flac; codecs="flac"'
'audio/wav; codecs="1"'