Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove and disable next Skia version for Cobalt 23" #1781

Closed
wants to merge 5 commits into from

Conversation

sherryzy
Copy link
Contributor

This reverts commit 53b50e6.

b/304784019

@sherryzy sherryzy force-pushed the next_skia branch 7 times, most recently from cecdd44 to f8beb07 Compare October 11, 2023 22:44
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7153cc9) 58.53% compared to head (f59c882) 58.50%.
Report is 50 commits behind head on main.

Files Patch % Lines
starboard/elf_loader/program_table.cc 83.33% 3 Missing ⚠️
starboard/shared/modular/posix_mmap_wrappers.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   58.53%   58.50%   -0.04%     
==========================================
  Files        1908     1903       -5     
  Lines       94585    94526      -59     
==========================================
- Hits        55369    55305      -64     
- Misses      39216    39221       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sherryzy sherryzy requested a review from kaidokert October 12, 2023 19:48
@sherryzy sherryzy changed the title [Testing] Revert "Remove and disable next Skia version for Cobalt 23" Revert "Remove and disable next Skia version for Cobalt 23" Oct 12, 2023
@sherryzy sherryzy marked this pull request as draft December 20, 2023 02:48
@sherryzy sherryzy force-pushed the next_skia branch 2 times, most recently from 8ad20db to 06d8d0f Compare December 20, 2023 04:12
@sherryzy sherryzy force-pushed the next_skia branch 2 times, most recently from c9e7965 to cb8d4ea Compare January 24, 2024 18:16
@sherryzy sherryzy marked this pull request as ready for review January 24, 2024 18:20
@sherryzy sherryzy force-pushed the next_skia branch 7 times, most recently from 229ade5 to 253e9f7 Compare January 25, 2024 18:34
@sherryzy sherryzy force-pushed the next_skia branch 4 times, most recently from 4b4b536 to babe6bc Compare January 25, 2024 21:26
@sherryzy sherryzy marked this pull request as draft January 25, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant