Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hardware accelerometer as input device #1883

Conversation

iuriionishchenko
Copy link
Collaborator

Functionality to handle data from hardware accelerometer was added.

b/128001846

Change-Id: I46c7e18bb033399213bb5a6a7d58ce54b533703a

Functionality to handle data from hardware accelerometer was added.

b/128001846

Change-Id: I46c7e18bb033399213bb5a6a7d58ce54b533703a
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1883 (58f94e7) into main (e9e6d75) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
- Coverage   57.77%   57.74%   -0.03%     
==========================================
  Files        1915     1915              
  Lines       95111    95118       +7     
==========================================
- Hits        54946    54929      -17     
- Misses      40165    40189      +24     
Files Coverage Δ
cobalt/system_window/input_event.h 0.00% <0.00%> (ø)
cobalt/system_window/system_window.cc 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

@xiaomings xiaomings requested review from jellefoks and removed request for xiaomings November 7, 2023 01:00
// Input from a gyroscope
//
// Produces |Input| event
kSbInputDeviceGyroSensor,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y4vor WDYT about this addition to Starboard?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please guard all API changes with the SB_API_VERSION checks. Also update starboard/CHANGELOG.md.

Here are the instructions of how to introduce a Starboard API change:
https://g3doc.corp.google.com/company/teams/cobalt/team/components/starboard.md#make-changes-in-trunk-to-the-latest-unreleased-starboard-version1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have access to this doc. Could you share it with us via docs.google.com?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on an org decision today, we won't be planning new changes for NX so this CL won't be needed at this time. Apologies for the timing of this happening after you started the effort on this CL. I'll close the PR and link to it in the bug for future reference if we ever need to reconsider using accelerometer.

@jellefoks jellefoks requested a review from y4vor November 9, 2023 19:22
@gbournou gbournou closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants