-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hardware accelerometer as input device #1883
Use hardware accelerometer as input device #1883
Conversation
Functionality to handle data from hardware accelerometer was added. b/128001846 Change-Id: I46c7e18bb033399213bb5a6a7d58ce54b533703a
Codecov Report
@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 57.77% 57.74% -0.03%
==========================================
Files 1915 1915
Lines 95111 95118 +7
==========================================
- Hits 54946 54929 -17
- Misses 40165 40189 +24
|
// Input from a gyroscope | ||
// | ||
// Produces |Input| event | ||
kSbInputDeviceGyroSensor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@y4vor WDYT about this addition to Starboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please guard all API changes with the SB_API_VERSION checks. Also update starboard/CHANGELOG.md.
Here are the instructions of how to introduce a Starboard API change:
https://g3doc.corp.google.com/company/teams/cobalt/team/components/starboard.md#make-changes-in-trunk-to-the-latest-unreleased-starboard-version1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have access to this doc. Could you share it with us via docs.google.com?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on an org decision today, we won't be planning new changes for NX so this CL won't be needed at this time. Apologies for the timing of this happening after you started the effort on this CL. I'll close the PR and link to it in the bug for future reference if we ever need to reconsider using accelerometer.
Functionality to handle data from hardware accelerometer was added.
b/128001846
Change-Id: I46c7e18bb033399213bb5a6a7d58ce54b533703a