Add assert for stub platform on windows host. #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
+ Coverage 57.71% 57.75% +0.03%
==========================================
Files 1907 1915 +8
Lines 95190 95118 -72
==========================================
- Hits 54937 54933 -4
+ Misses 40253 40185 -68 ☔ View full report in Codecov by Sentry. |
y4vor
approved these changes
Nov 15, 2023
The stub platform currently can not be compiled on windows and instead shows cryptic gn errors. To avoid this confusion, assert when trying to configure stub platform on a windows host.
jellefoks
force-pushed
the
add_build_config_warning
branch
from
502b5d9 to
3a1826c
Compare
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
The stub platform currently can not be compiled on windows and instead shows cryptic gn errors. To avoid this confusion, assert when trying to configure stub platform on a windows host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stub platform currently can not be compiled on windows and instead shows cryptic gn errors.
To avoid this confusion, assert when trying to configure stub platform on a windows host.
b/0nobug