Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using imp python module. #2011

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Stop using imp python module. #2011

merged 1 commit into from
Nov 23, 2023

Conversation

isarkis
Copy link
Member

@isarkis isarkis commented Nov 22, 2023

imp module has been removed from Python 3.12

b/312559511

Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look wrong to me

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee2f99f) 57.66% compared to head (ffc2b42) 57.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
+ Coverage   57.66%   57.68%   +0.02%     
==========================================
  Files        1907     1907              
  Lines       95181    95181              
==========================================
+ Hits        54885    54908      +23     
+ Misses      40296    40273      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imp module has been removed from Python 3.12

b/312559511
@isarkis isarkis merged commit c5a4b3c into youtube:main Nov 23, 2023
@isarkis isarkis deleted the imp branch November 23, 2023 01:20
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
imp module has been removed from Python 3.12

b/312559511
@isarkis isarkis added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 29, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jan 29, 2024
imp module has been removed from Python 3.12

b/312559511

(cherry picked from commit c5a4b3c)
isarkis added a commit that referenced this pull request Jan 29, 2024
Refer to the original PR: #2011

imp module has been removed from Python 3.12

b/312559511

Co-authored-by: Igor Sarkisov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch ignore-for-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants