Add the RTLD_DEEPBIND flag when dlopen-ing FFmpeg libraries. #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the cast runtime when built out of chromium will segfault in starboard's FFmpeg decoder. The issue is that chromium builds a newer version of FFmpeg, and (without RTLD_DEEPBIND) some of the symbols in FFmpeg get resolved as the chromium versions. This likely causes a segfault due to struct size changes (in my case, the segfault was in av_buffer_unref). See the bug for more details, including a full stack trace. Bug: b/313524200
Bug: b/313524200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the cast runtime when built out of chromium will segfault in starboard's FFmpeg decoder. The issue is that chromium builds a newer version of FFmpeg, and (without RTLD_DEEPBIND) some of the symbols in FFmpeg get resolved as the chromium versions. This likely causes a segfault due to struct size changes (in my case, the segfault was in av_buffer_unref). See the bug for more details, including a full stack trace.
Bug: b/313524200