Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cobalt http caching code to //cobalt. #2047

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

aee-google
Copy link
Contributor

@aee-google aee-google commented Dec 6, 2023

b/313661860

@aee-google aee-google force-pushed the move-cobalt-backend branch 2 times, most recently from 41ac164 to 94bb57f Compare December 11, 2023 20:49
@andrewsavage1
Copy link
Contributor

@jellefoks could you take a look at this as well? I don't have much pre-existing knowledge about caching so while a lot of this looks fine, some of it is definitely foreign

@aee-google aee-google force-pushed the move-cobalt-backend branch 2 times, most recently from 772ba96 to f032f2a Compare December 12, 2023 00:07
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 146 lines in your changes are missing coverage. Please review.

Comparison is base (35fd0c5) 58.64% compared to head (202ac82) 58.47%.
Report is 4 commits behind head on main.

❗ Current head 202ac82 differs from pull request most recent head 2cd3326. Consider uploading reports for the commit 2cd3326 to get more accurate results

Files Patch % Lines
cobalt/h5vcc/h5vcc_storage.cc 0.00% 51 Missing ⚠️
cobalt/network/disk_cache/cobalt_disk_cache.cc 0.00% 31 Missing ⚠️
cobalt/network/disk_cache/cobalt_backend_impl.cc 0.00% 22 Missing ⚠️
cobalt/cache/cache.cc 68.42% 12 Missing ⚠️
cobalt/network/url_request_context.cc 18.18% 9 Missing ⚠️
cobalt/loader/net_fetcher.cc 20.00% 4 Missing ⚠️
cobalt/loader/script_loader_factory.cc 0.00% 4 Missing ⚠️
...obalt/network/disk_cache/cobalt_backend_factory.cc 33.33% 4 Missing ⚠️
cobalt/network/disk_cache/cobalt_backend_impl.h 0.00% 3 Missing ⚠️
...obalt/worker/service_worker_persistent_settings.cc 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2047      +/-   ##
==========================================
- Coverage   58.64%   58.47%   -0.18%     
==========================================
  Files        1902     1908       +6     
  Lines       94044    93857     -187     
==========================================
- Hits        55155    54885     -270     
- Misses      38889    38972      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aee-google aee-google enabled auto-merge (squash) December 12, 2023 19:10
cobalt/cache/cache.cc Show resolved Hide resolved
cobalt/cache/cache.cc Outdated Show resolved Hide resolved
cobalt/loader/net_fetcher.cc Outdated Show resolved Hide resolved
b/313661860

Change-Id: I84b2cbc2fa07a6c90f4cfc1e57f8784a02c0b37c
@andrewsavage1
Copy link
Contributor

I saw some evergreen presubmits failing—I assume those are failing in trunk too?

@aee-google aee-google merged commit 22900cc into youtube:main Dec 13, 2023
328 of 330 checks passed
@aee-google aee-google deleted the move-cobalt-backend branch December 13, 2023 21:59
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants