Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SbDirectoryCreate #2049

Merged
merged 45 commits into from
Jan 30, 2024
Merged

Conversation

madhurajayaraman
Copy link
Contributor

b/302730696

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4657405) 58.50% compared to head (d3fd0c0) 58.49%.
Report is 7 commits behind head on main.

Files Patch % Lines
cobalt/browser/splash_screen_cache.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
- Coverage   58.50%   58.49%   -0.02%     
==========================================
  Files        1903     1902       -1     
  Lines       94555    94532      -23     
==========================================
- Hits        55317    55292      -25     
- Misses      39238    39240       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madhurajayaraman madhurajayaraman marked this pull request as ready for review January 23, 2024 23:50
@andrewsavage1
Copy link
Contributor

andrewsavage1 commented Jan 24, 2024

Here we use both the windows api and the posix api where in general we would just use the posix api have windows mimic it as required, with potential future changes to directly use the windows api. Why the change in this PR?

b/302730696

Change-Id: I55efe035d9a0379e5c10b10b5701c6cef13f577c
b/302730696

Change-Id: Ia09c07522348fcfc42c8a84db066ef66d2d160f2
b/302730696

Change-Id: Ic728cfe7477834c3589453f7d07f4eb4eeadc36b
b/302730696

Change-Id: Ia2b302a7bb4ecc38fef13ac527efe5df23628a2f
b/302730696

Change-Id: I7e073f7db038b11151dfd11c4080f46a3c227407
b/302730696

Change-Id: I25eff9b0fcb9277982d4b02faf21411728f57632
b/302730696

Change-Id: I87867480e9a0e0516e5d0672205203d6e893369a
b/302730696

Change-Id: Ifeea2ff18cc8c472c6691b81508dd05041a919a3
b/302730696

Change-Id: Iaed194654f8c2937f9969ab21c78488963a9507f
b/302730696

Change-Id: I3dc21179ba6924cf3d2af9f4c5d0a8a078873190
b/302730696

Change-Id: I8201175ecf2465acc665efdd0dc13e9b35ea2681
b/302730696

Change-Id: I1c3e03dbf082fa7cd032dac6142e70ec9e88bdb0
b/302730696

Change-Id: I856c3e66326f941cdbb2bb4d13add720882bab5c
b/302730696

Change-Id: I0cf701b94cdda6764489b336ec77ecdca31082f7
b/302730696

Change-Id: I31e3084c9c56af3f07f651135b6dd383358f0cc4
b/302730696

Change-Id: Ie14bfc2c2791dde3a669d89b0cb451d7abcc5985
b/302730696

Change-Id: I5471491112ad1f81c4988a9822a5183345ed168d
b/302730696

Change-Id: I7dccdbc307aadb5b1af606e3f660faa6a80ee29e
b/302730696

Change-Id: Idaecdf58b511f9e67d98dee5f12e2b6c40bc72fc
b/302730696

Change-Id: Idce304e3eb24b207104b42ed3138ccd38f9c78d2
b/302730696

Change-Id: I4d3aa78534f30cc9924329d949fd4064d495cab8
b/302730696

Change-Id: Ibefa6496648ed2b408455c2b312eef020a93154b
@madhurajayaraman madhurajayaraman marked this pull request as ready for review January 30, 2024 18:30
Copy link
Contributor

@y4vor y4vor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update starboard/CHANGELOG.md

starboard/shared/win32/posix_emu/stat.cc Outdated Show resolved Hide resolved
b/302730696

Change-Id: Ib3af2c7b9c516499d5c26d8d2e9e56c14efdb98e
b/302730696

Change-Id: I4a0a3b056b6ba935f8e3bd1ae41e021fe9016cbc
starboard/CHANGELOG.md Outdated Show resolved Hide resolved
b/302730696

Change-Id: I1f403e5f56991828e830de9c6dfb9ee78f7d8455
Copy link
Contributor

@andrewsavage1 andrewsavage1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure this is tested on internal platforms

base/files/file_util_starboard.cc Outdated Show resolved Hide resolved
base/files/file_util_starboard.cc Outdated Show resolved Hide resolved
b/302730696

Change-Id: I02575a779391ba15c13c1d53ff56cafa144b65f9
@madhurajayaraman madhurajayaraman merged commit 40d4816 into youtube:main Jan 30, 2024
332 of 334 checks passed
@madhurajayaraman madhurajayaraman deleted the sbdir branch January 30, 2024 22:42
isarkis added a commit that referenced this pull request Feb 1, 2024
isarkis added a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants