Disable BuildTimeUnittest #2066
Conversation
build/timestamp.gni
Outdated
| @@ -28,4 +28,7 @@ if (is_official_build) { | |||
| # changes to keep this up to date. (Bots run gn on each build, and for devs | |||
| # the timestamp being 100% accurate doesn't matter.) | |||
| # See compute_build_timestamp.py for tradeoffs for picking the timestamp. | |||
| build_timestamp = "123" | |||
| build_timestamp = exec_script(compute_build_timestamp, | |||
There was a problem hiding this comment.
In order for reproducible builds to work, we don't want to put a timestamp in our build—if the test is solely checking this build_timestamp value, I think we should disable the test
There was a problem hiding this comment.
That is what the test is trying to test.
we don't want to put a timestamp in our build
So is this a permanently or temporarily decision? If we just don't want to put a timestamp in our build, I agree we can just disable the test.
There was a problem hiding this comment.
It's a permanent decision, at least for now. Let's just disable the test
sherryzy
force-pushed
the
base_unittest
branch
from
eac59d0 to
00e9d7d
Compare
sherryzy
changed the title
base/BUILD.gn
Outdated
| @@ -3132,7 +3132,8 @@ test("base_unittests") { | |||
| "big_endian_unittest.cc", | |||
| "bit_cast_unittest.cc", | |||
| "bits_unittest.cc", | |||
| "build_time_unittest.cc", | |||
| # Cobalt builds don't include build timestamps. | |||
| # "build_time_unittest.cc", | |||
There was a problem hiding this comment.
We should either have a conditional checking use_cobalt_customizations that removes the entire source file if we don't want any of it or we should add the DISABLED_ gtest macro if we're disabling just certain tests in the file, that way we can have easier ways of tracking disabled tests
sherryzy
force-pushed
the
base_unittest
branch
from
00e9d7d to
b6263ae
Compare
base/BUILD.gn
Outdated
| if (use_cobalt_customizations) { | ||
| sources += [ | ||
| # Cobalt builds don't include build timestamps. | ||
| # "build_time_unittest.cc", |
There was a problem hiding this comment.
Sorry for the confusion, I meant to leave it in the original list of sources and to add a sources -= here to be clear about which files we don't compile
b/298237650
sherryzy
force-pushed
the
base_unittest
branch
from
b6263ae to
5dbb793
Compare
sherryzy
merged commit f76d02b
into
youtube:feature/all-upstream-update
b/298237650
b/316012657