Revert "Deprecate SbStringFormat functions" #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 35fd0c5.
andrewsavage1
approved these changes
Dec 13, 2023
Datadog ReportBranch report: ✅ |
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Reverts youtube#1999 as it broke XB1 and PS5 b/316211534
maxz-lab
added a commit
that referenced
this pull request
Dec 21, 2023
Replace SbStringFormat*() calls with POSIX sprintf. SbStringFormat -> vsnprintf SbStringFormatF -> snprintf SbStringFormatWide -> vswprintf SbStringFormatUnsafeF -> sprintf Backward compatibility is protected by "SB_API_VERSION < 16". A clean up CL is needed to take care of references of the deprecated APIs at everywhere else. This reverts PR#2083. b/307941391 Change-Id: I437ff3d7bf735b46767867ea844aeffb28e58b4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1999 as it broke XB1 and PS5
b/316211534