Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PosixMemoryMapTest.CanChangeMemoryProtection. #2256

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

y4vor
Copy link
Contributor

@y4vor y4vor commented Jan 20, 2024

The test is crashing in the linux coverage build.

b/321315344

Change-Id: I1053939bbec2af0e5d9922a6a43adbe868c62207

The test is crashing in the linux coverage build.

b/321315344

Change-Id: I1053939bbec2af0e5d9922a6a43adbe868c62207
@y4vor y4vor requested a review from oxve January 20, 2024 00:19
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7153cc9) 58.53% compared to head (49d71f6) 58.49%.
Report is 23 commits behind head on main.

Files Patch % Lines
starboard/elf_loader/program_table.cc 83.33% 3 Missing ⚠️
starboard/shared/modular/posix_mmap_wrappers.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2256      +/-   ##
==========================================
- Coverage   58.53%   58.49%   -0.05%     
==========================================
  Files        1908     1901       -7     
  Lines       94585    94207     -378     
==========================================
- Hits        55369    55109     -260     
+ Misses      39216    39098     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y4vor y4vor merged commit e27bdec into youtube:main Jan 20, 2024
334 of 335 checks passed
@y4vor y4vor deleted the disable_pmem_test branch May 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants