Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pthread_mutex APIs. #2262

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Introduce pthread_mutex APIs. #2262

merged 1 commit into from
Feb 3, 2024

Conversation

y4vor
Copy link
Contributor

@y4vor y4vor commented Jan 22, 2024

  • Add support for pthread_mutex_init, pthread_mutex_destroy, pthread_mutex_lock, pthread_mutex_unlock and pthread_mutex_trylock.

b/302335657

Change-Id: I8774ddb8ad466b7342e045402b170a719f2e1a81

@y4vor y4vor force-pushed the depr_sbthread branch 5 times, most recently from 45292aa to 09c982b Compare January 24, 2024 02:45
@y4vor y4vor requested a review from andrewsavage1 as a code owner January 24, 2024 02:45
@y4vor y4vor marked this pull request as draft January 24, 2024 03:15
@y4vor y4vor force-pushed the depr_sbthread branch 3 times, most recently from 2e3528d to 2951e81 Compare January 29, 2024 16:58
@y4vor y4vor force-pushed the depr_sbthread branch 2 times, most recently from 26388a1 to 98211ff Compare January 29, 2024 22:36
@y4vor y4vor requested a review from gbournou January 31, 2024 21:32
@y4vor y4vor marked this pull request as ready for review January 31, 2024 21:32
@y4vor y4vor requested a review from a team as a code owner January 31, 2024 21:32
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (49a7514) 58.42% compared to head (98c7484) 58.40%.
Report is 2 commits behind head on main.

Files Patch % Lines
starboard/shared/modular/posix_pthread_wrappers.cc 0.00% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2262      +/-   ##
==========================================
- Coverage   58.42%   58.40%   -0.03%     
==========================================
  Files        1901     1902       +1     
  Lines       94669    94717      +48     
==========================================
+ Hits        55310    55316       +6     
- Misses      39359    39401      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add support for pthread_mutex_init, pthread_mutex_destroy,
  pthread_mutex_lock, pthread_mutex_unlock and pthread_mutex_trylock.

b/302335657

Change-Id: I8774ddb8ad466b7342e045402b170a719f2e1a81
@y4vor y4vor merged commit e158e9b into youtube:main Feb 3, 2024
383 of 385 checks passed
@y4vor y4vor deleted the depr_sbthread branch May 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants