Update BoringSSL from Chromium 96.0.4664.219 #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: third_party/boringssl git-subtree-split: 6a496db5ef7219101beacceca9566367c9cb1a09
All the test vectors testing key length greater than the block length were mislabelled as key length being equal to the block length. Add a note to these test vectors indicating they are directly from the NIST tests with the misleading input intact. Change-Id: I9fe87971265ad48e9b835fccbe92306e1670b4d6 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/49705 Reviewed-by: David Benjamin <[email protected]> Commit-Queue: David Benjamin <[email protected]> git-subtree-dir: third_party/boringssl/src git-subtree-split: 87f316d7748268eb56f2dc147bd593254ae93198
dahlstrom-g
force-pushed
the
boringssl-96.0.4664.219
branch
from
9182e8f to
3683570
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
+ Coverage 58.45% 58.58% +0.12%
==========================================
Files 1904 1904
Lines 94327 94522 +195
==========================================
+ Hits 55138 55371 +233
+ Misses 39189 39151 -38 ☔ View full report in Codecov by Sentry. |
jellefoks
approved these changes
Jan 23, 2024
dahlstrom-g
force-pushed
the
boringssl-96.0.4664.219
branch
from
3683570 to
8377e5b
Compare
Issue: 128434484
lh_new is a very short name to be claiming. (cherry picked from commit ec8c67dfbc01eb13f16a40f6c8da6299a65a540c) Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/48206
Trusty wants to seed from a different RNG than the one that supplies per-draw entropy. This is a no-op change unless you're substituting in your own implementations of these functions. To see that it's a no-op in urandom.c, note that it only changes the |seed| argument to |fill_with_entropy|. That causes the value of |extra_getrandom_flags_for_seed_bss_get| to be ORed into the flags, but that value will always be zero unless it's an Android FIPS build. (cherry picked from commit 519c2986c73c23461b130ad19b93fd7d081353d5) Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/48485
Instead let crypto/fipsmodule/md5/internal.h define it conditionally. That preprocessor logic was moved there from crypto/fipsmodule/md5/md5.c by BoringSSL commit 5e350d13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/309016038