Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CoAT to use jdk 17 #2268

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Upgrade CoAT to use jdk 17 #2268

merged 1 commit into from
Jan 26, 2024

Conversation

zhongqiliang
Copy link
Contributor

We are lucky that the current Gradle version already supports jdk 17.

We need to update buildbots to reference jdk 17 before we submit this CL.

b/321986843

@zhongqiliang zhongqiliang force-pushed the update_jdk_17 branch 2 times, most recently from e1e2680 to ad18dbc Compare January 23, 2024 19:28
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Jan 23, 2024

Datadog Report

Branch report: update_jdk_17
Commit report: ddd44af
Test service: cobalt

✅ 0 Failed, 29854 Passed, 1 Skipped, 9m 51.73s Wall Time

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61c20a2) 58.53% compared to head (ddd44af) 58.50%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
- Coverage   58.53%   58.50%   -0.03%     
==========================================
  Files        1904     1903       -1     
  Lines       94522    94542      +20     
==========================================
- Hits        55328    55312      -16     
- Misses      39194    39230      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongqiliang zhongqiliang force-pushed the update_jdk_17 branch 8 times, most recently from 49a01b3 to c0ad23d Compare January 25, 2024 22:18
@zhongqiliang zhongqiliang merged commit 79c1ce0 into main Jan 26, 2024
333 of 334 checks passed
@zhongqiliang zhongqiliang deleted the update_jdk_17 branch January 26, 2024 01:19
@zhongqiliang zhongqiliang added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 26, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Jan 26, 2024
We are lucky that the current Gradle version already supports jdk 17.

We need to update buildbots to reference jdk 17 before we submit this
CL.

b/321986843

Co-authored-by: Colin Liang <[email protected]>
(cherry picked from commit 79c1ce0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants