-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create test cases and win32 emu layer for bind() #2441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 29891 Passed, 1 Skipped, 11m 18.12s Wall Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
==========================================
+ Coverage 58.21% 58.22% +0.01%
==========================================
Files 1787 1787
Lines 84069 84076 +7
==========================================
+ Hits 48938 48951 +13
+ Misses 35131 35125 -6 ☔ View full report in Codecov by Sentry. |
fdb12d9
to
a40a411
Compare
7dbb17a
to
235f88f
Compare
y4vor
reviewed
Feb 27, 2024
6145219
to
7fe95b0
Compare
The socket functions on win32 takes kernel handler instead file descriptor, which requires a wrapper to match posix interface. This change provides emulation for bind(), listen(), accept(), connect(), and supportive function getifaddrs(), getsockname() b/302701164 Change-Id: I5b248c12ce28b6e9c8cc889c2bb3417107555be8
af83ee9
to
b7f9d12
Compare
y4vor
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create tests and win32 emu layer for socket functions
The socket functions on win32 takes kernel handler instead
file descriptor, which requires a wrapper to match posix interface.
This change provides emulation for
bind(), listen(), accept(), connect()
This change needs CL275526 for PS5 support.
b/302701164
Change-Id: I5b248c12ce28b6e9c8cc889c2bb3417107555be8