Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test cases and win32 emu layer for bind() #2441

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

maxz-lab
Copy link
Contributor

@maxz-lab maxz-lab commented Feb 15, 2024

Create tests and win32 emu layer for socket functions

The socket functions on win32 takes kernel handler instead
file descriptor, which requires a wrapper to match posix interface.

This change provides emulation for
bind(), listen(), accept(), connect()

This change needs CL275526 for PS5 support.

b/302701164

Change-Id: I5b248c12ce28b6e9c8cc889c2bb3417107555be8

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Feb 15, 2024

Datadog Report

Branch report: maxz-sb16-socket-listen
Commit report: 9bebba7
Test service: cobalt

✅ 0 Failed, 29891 Passed, 1 Skipped, 11m 18.12s Wall Time

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (f31c259) to head (9bebba7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2441      +/-   ##
==========================================
+ Coverage   58.21%   58.22%   +0.01%     
==========================================
  Files        1787     1787              
  Lines       84069    84076       +7     
==========================================
+ Hits        48938    48951      +13     
+ Misses      35131    35125       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxz-lab maxz-lab force-pushed the maxz-sb16-socket-listen branch 13 times, most recently from fdb12d9 to a40a411 Compare February 22, 2024 18:13
@maxz-lab maxz-lab force-pushed the maxz-sb16-socket-listen branch from 7dbb17a to 235f88f Compare February 27, 2024 04:20
@maxz-lab maxz-lab force-pushed the maxz-sb16-socket-listen branch 2 times, most recently from 6145219 to 7fe95b0 Compare February 27, 2024 20:07
The socket functions on win32 takes kernel handler instead
file descriptor, which requires a wrapper to match posix interface.

This change provides emulation for
bind(), listen(), accept(), connect(), and supportive function
getifaddrs(), getsockname()

b/302701164

Change-Id: I5b248c12ce28b6e9c8cc889c2bb3417107555be8
@maxz-lab maxz-lab force-pushed the maxz-sb16-socket-listen branch from af83ee9 to b7f9d12 Compare February 28, 2024 00:18
@maxz-lab maxz-lab marked this pull request as ready for review February 28, 2024 04:03
@maxz-lab maxz-lab merged commit 09b12c8 into main Feb 28, 2024
340 of 341 checks passed
@maxz-lab maxz-lab deleted the maxz-sb16-socket-listen branch February 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants