Add Posix compliance test for setsockopt. #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2449 +/- ##
==========================================
- Coverage 58.02% 57.83% -0.20%
==========================================
Files 1781 1884 +103
Lines 83398 92016 +8618
==========================================
+ Hits 48390 53213 +4823
- Misses 35008 38803 +3795 ☔ View full report in Codecov by Sentry. |
haozheng-cobalt
force-pushed
the
socketopt
branch
3 times, most recently
from
9baaf2d to
93071e1
Compare
b/321004711 Change-Id: I207e05f2785f7c54e0d8cf2efaf4afc5c42d1f39 Change-Id: I3902ef278537a7cb44198021b6972280542f2dbb
haozheng-cobalt
force-pushed
the
socketopt
branch
6 times, most recently
from
93b9d3f to
1e1dd92
Compare
Change-Id: Ica48103af77179eb1f1cd328d76d497cbb8f82ba
haozheng-cobalt
force-pushed
the
socketopt
branch
4 times, most recently
from
757898f to
7eb0bba
Compare
gbournou
previously requested changes
Feb 21, 2024
haozheng-cobalt
force-pushed
the
socketopt
branch
2 times, most recently
from
6768676 to
8d3e39e
Compare
y4vor
reviewed
Feb 22, 2024
haozheng-cobalt
force-pushed
the
socketopt
branch
3 times, most recently
from
3f04d97 to
8877ca3
Compare
gbournou
reviewed
Feb 23, 2024
y4vor
reviewed
Feb 23, 2024
starboard/nplb/posix_compliance/posix_socket_set_options_test.cc
Outdated
Show resolved
Hide resolved
haozheng-cobalt
force-pushed
the
socketopt
branch
3 times, most recently
from
eaf6933 to
918c39f
Compare
Change-Id: I0a750dd7cba9d268541d1f9b725b777f6a1740cf
haozheng-cobalt
force-pushed
the
socketopt
branch
from
918c39f to
788166f
Compare
y4vor
approved these changes
Feb 27, 2024
haozheng-cobalt
dismissed
gbournou’s stale review
all reviews have been resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/321004711