Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SbFileOpen and SbFileClose. #2460

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Deprecate SbFileOpen and SbFileClose. #2460

merged 4 commits into from
Mar 1, 2024

Conversation

yjzhang111
Copy link
Contributor

b/302715109

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (34f16d4) to head (c75c806).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
+ Coverage   58.21%   58.22%   +0.01%     
==========================================
  Files        1787     1787              
  Lines       84076    84077       +1     
==========================================
+ Hits        48945    48954       +9     
+ Misses      35131    35123       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yjzhang111 yjzhang111 force-pushed the yjzhang-sbfile branch 2 times, most recently from 0c30f7b to 11d75e6 Compare February 22, 2024 07:50
y4vor
y4vor reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@y4vor y4vor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for win32 the open would have to coordinate with the sb_close.
starboard/shared/win32/posix_emu/socket.cc

starboard/shared/win32/file_close.cc Outdated Show resolved Hide resolved
third_party/musl/src/starboard/fcntl/open.c Outdated Show resolved Hide resolved
@yjzhang111 yjzhang111 force-pushed the yjzhang-sbfile branch 2 times, most recently from da11c5a to fef4a40 Compare February 28, 2024 22:02
@yjzhang111 yjzhang111 requested review from y4vor and maxz-lab February 29, 2024 00:09
@yjzhang111
Remove musl implementations.
d084474 
Change-Id: I20e7215432d8172c585fe4e0d96427661cc9bf79
@yjzhang111
Change fd-socket map to fd-FileOrSocket map.
08e964b 
Change-Id: Ib46542f3892efb7c0a2a3bfee2545825c5c4e22a
@yjzhang111
Map windows file permissions to POSIX modes.
e99ffe9 
Change-Id: I2ce642acdc65c99cc9a2806a85eafeaf834b8679
@yjzhang111
Add test case for file modes with no Windows equivalent.
c75c806 
Change-Id: I4295eca915f886c816b5cb947800e20ab71a3fdc
@yjzhang111 yjzhang111 marked this pull request as ready for review March 1, 2024 00:35
@yjzhang111 yjzhang111 requested a review from y4vor March 1, 2024 00:49
@yjzhang111 yjzhang111 merged commit fa976d1 into youtube:main Mar 1, 2024
340 of 341 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y4vor y4vor y4vor approved these changes

@maxz-lab maxz-lab Awaiting requested review from maxz-lab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjzhang111 @y4vor