Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check artifact sizes action and add label for violation. #3813

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

haozheng-cobalt
Copy link
Contributor

@haozheng-cobalt haozheng-cobalt commented Jul 10, 2024

b/291954423

@haozheng-cobalt haozheng-cobalt force-pushed the artifact-size branch 12 times, most recently from 4bfe012 to be1db76 Compare July 12, 2024 05:38
b/291954423

Change-Id: Ic9eeafba033e0bcdf066fe6e58992c31a1e1e35d
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.77%. Comparing base (2de8ba1) to head (608539f).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
+ Coverage   57.75%   57.77%   +0.01%     
==========================================
  Files        1779     1768      -11     
  Lines       86573    86410     -163     
==========================================
- Hits        50001    49922      -79     
+ Misses      36572    36488      -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haozheng-cobalt haozheng-cobalt force-pushed the artifact-size branch 14 times, most recently from 34648bd to 0e8bc80 Compare July 16, 2024 03:15
@haozheng-cobalt haozheng-cobalt force-pushed the artifact-size branch 9 times, most recently from b6809c7 to 608539f Compare August 8, 2024 22:16
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
.github/actions/check_artifact_size/action.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally hit Approve instead of Comment. Only way to change it is to request changes.

@haozheng-cobalt haozheng-cobalt force-pushed the artifact-size branch 9 times, most recently from f09bf68 to 0e1bd72 Compare August 9, 2024 17:58
Change-Id: I14793250ac2cb4a0ed824ee173cd13602189aec5
@haozheng-cobalt haozheng-cobalt enabled auto-merge (squash) August 9, 2024 21:18
@haozheng-cobalt haozheng-cobalt changed the title Check artifact size pre-submit for evergreen Add check artifact sizes action and add label for violation. Aug 9, 2024
auto-merge was automatically disabled August 9, 2024 22:04

Pull Request is not mergeable

@haozheng-cobalt haozheng-cobalt enabled auto-merge (squash) August 9, 2024 22:15
@haozheng-cobalt haozheng-cobalt merged commit 9545024 into youtube:main Aug 9, 2024
332 of 333 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants