Print an error message and return instead of crash #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the loader does mark the slot as |
|
I think we should write a YTS Evergreen test case for this. I can file a feature request to track that, but let me know if you've already filed one / were planning to. |
hlwarriner
approved these changes
Aug 6, 2024
Yeah, I haven't. Feel free to file a request. It'll be hard to mock this scenario with YTS tho. |
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd (cherry picked from commit 7a23f54)
yuying-y
added a commit
that referenced
this pull request
Aug 8, 2024
…ash (#3948) Refer to the original PR: #3939 When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd Co-authored-by: yuying-y <[email protected]>
yuying-y
added
cp-23.lts.1+
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd (cherry picked from commit 7a23f54)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd (cherry picked from commit 7a23f54)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd (cherry picked from commit 7a23f54)
yuying-y
added a commit
that referenced
this pull request
Aug 8, 2024
…ash (#3952) Refer to the original PR: #3939 When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd Co-authored-by: yuying-y <[email protected]>
yuying-y
added a commit
that referenced
this pull request
Aug 8, 2024
…ash (#3954) Refer to the original PR: #3939 When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd Co-authored-by: yuying-y <[email protected]>
yuying-y
added a commit
that referenced
this pull request
Aug 9, 2024
…ash (#3953) Refer to the original PR: #3939 When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image. b/357947368 Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd Co-authored-by: yuying-y <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the address of a symbol couldn't be found, the app should return instead of crash. The address is validated by the caller, which returns false if address is NULL. Eventually the loader gets the error message, and reverts back to the previous good image.
b/357947368
Change-Id: I74b9aa600c281a74ef817af0cd97f0cda4ab91cd