-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code clean up to remove starboard/common/atomic usage #3944
Code clean up to remove starboard/common/atomic usage #3944
Conversation
8236168
to
a4584c7
Compare
c4a9908
to
6901f77
Compare
40c1d8e
to
b9b7a82
Compare
starboard/shared/starboard/player/filter/punchout_video_renderer_sink.h
Outdated
Show resolved
Hide resolved
starboard/shared/starboard/player/filter/video_renderer_internal_impl.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed, and changes look correct and good.
However - lets please take this opportunity to also consistently and correctly default-initialize the variables affected by this change.
It seems that the used style is generally std::atomic_var foo{value};
so let's use that everywhere for in-class initialization.
Of course, please doublecheck that the values match the expectation in code as well - in most cases atomic_bool
is expected to be default false
, but not always.
c23c6d6
to
edb1228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now - please wait until internal builds come back green and Hao has a chance to review as well.
There are 5 failing and 1 errored checks. But I don't have access to full logs to investigate and fix them. Can you provide me? |
With on-device tests those are often flaky failures on the first try. When you see those, please click "Retry" on the failed jobs and see if one retry cleans them up. We don't currently auto-retry yet. |
Hm there's lint failure from wrong include order - can we get that fixed please as well ? |
b/353387554 Change-Id: I693905b5daac088c7e6e6acdb5e86f5feac4f3e5
Head branch was pushed to by a user without write access
f15675a
to
38173d3
Compare
Code clean up to remove starboard/common/atomic usage Test-On-Device: true b/353387554
Code clean up to remove starboard/common/atomic usage
Test-On-Device: true
b/353387554