Clean up socket.h header #4158
Merged
Clean up socket.h header #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to be larger cleanup, so each of the commits is pretty self-contained for ease of reviewing. Each commit should take out one or two functions, or do some other type of specific cleanup (specified in the commit description). |
madhurajayaraman
force-pushed
the
socket-cleanup-2
branch
3 times, most recently
from
c73e067 to
64ff821
Compare
Change-Id: I98cc8b4dc1d503218a84c0072ed294d76271661e
madhurajayaraman
force-pushed
the
socket-cleanup-2
branch
from
64ff821 to
c06c923
Compare
Change-Id: I5b6da0eb6631472c8130689dd39a10e64b254f8c
Change-Id: Id482f86a97edabd86ba7d7a5e8a98e7ade758b75
Change-Id: I78c0b0642236d977c9b57602b9376e3471c71a43
Change-Id: I1891511b69fa0c8a905026d3a46f9bf41ad8ab00
Change-Id: I7592d5592d3cbbbe788263b31aaa92ec6f756d88
Change-Id: I112f93c1c544cd4a4d626958e0f52e438cca712c
madhurajayaraman
force-pushed
the
socket-cleanup-2
branch
from
c06c923 to
e9d1c3c
Compare
maxz-lab
approved these changes
Sep 27, 2024
y4vor
reviewed
Sep 27, 2024
kaidokert
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Same comment as Yavor: For the stuff we kept with SB_VERSION 17 and 16, we need to follow up and ensure there are equivalent POSIXy tests, if applicable. Net test coverage should remain ~ unchanged
But this is fine to go in, a huge clean-up, and then we sort the test coverage out separately. I actually recommend landing this Monday, before we switch to Chrobalt branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/369182833