Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use posix socket APIs #4206

Closed
wants to merge 6 commits into from
Closed

Use posix socket APIs #4206

wants to merge 6 commits into from

Conversation

maxz-lab
Copy link
Contributor

@maxz-lab maxz-lab commented Oct 4, 2024

This includes PR3601 and PR3904 on main branch, and a patch that uses starboard socket on win32.

b/302741384

Introduced API SbPosixSocketWaiterAdd, SbPosixSocketWaiterRemove and
  callback SbPosixSocketWaiterCallback.
Tests added are
  SbPosixSocketWaiterAdd
  SbPosixSocketWaiterRemove
  SbPosixSocketWaiterWait
  SbPosixSocketWaiterWaitTimed
libevent and win32 SocketWaiter module supports both integer based
socket and
  SbSocket socket in SB16.

This is PR3601 on main branch.

b/302741384
Replace net/tcp&udp_starboard with net/tcp&udp_posix.

This is PR3904 on main branch.

b/302741384
@maxz-lab maxz-lab requested a review from jellefoks October 4, 2024 05:09
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y4vor These would have to go into an extension, right?

@jellefoks jellefoks requested a review from y4vor October 4, 2024 18:04
@maxz-lab maxz-lab force-pushed the cherry-pick-25.lts.1+-3601 branch 4 times, most recently from 575aa30 to de60f97 Compare October 7, 2024 02:58
@maxz-lab maxz-lab force-pushed the cherry-pick-25.lts.1+-3601 branch 2 times, most recently from 7cc1f98 to c674799 Compare October 15, 2024 04:42
Detect "_MSC_VER" on win32/xbox.

b/302741384
@maxz-lab maxz-lab force-pushed the cherry-pick-25.lts.1+-3601 branch from c674799 to 6c75f2b Compare October 16, 2024 15:51
The reverts the test change made in PR3904.

b/302741384
Change (PR3904) replaced recvmsg() with recvfrom unnecessarily. This change to restore the recvmsg().

b/302741384
@maxz-lab maxz-lab force-pushed the cherry-pick-25.lts.1+-3601 branch from 8451cb1 to 1e5af93 Compare October 18, 2024 18:07
@kaidokert kaidokert closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants