Implement cross-thread MediaSource attachments #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-ninja
force-pushed
the
cross-thread-media-source-attachments
branch
from
55fac9b to
2e35a64
Compare
at-ninja
changed the title
Port relevant Chromium code to the Cobalt 25 codebase to allow for `MediaSource` objects on a Dedicated Worker to render frames on a `HTMLMediaElement` owned by the main browser thread. Usage of this feature is gated behind the `MediaSource.EnableInWorkers` H5VCC flag. In addition, the `MediaElement.EnableUsingMediaSourceBufferedRange` and `MediaElement.EnableUsingMediaSourceAttachmentMethods` flags are also required as pre-requisite features. This commit does introduce mutex locks to the `SourceBuffer` and `MediaSource` classes that cannot be fully gated behind H5VCC flags. However, current usage of both classes is contained to single-threaded usecases. As such, the mutex lock code should be an effective no-op. This is based off of the following Chromium commits: * https://chromium-review.googlesource.com/c/chromium/src/+/2459431 * https://chromium-review.googlesource.com/c/chromium/src/+/2617351 * https://chromium-review.googlesource.com/c/chromium/src/+/2909389 b/338425382
at-ninja
force-pushed
the
cross-thread-media-source-attachments
branch
from
2e35a64 to
5fc5cd4
Compare
aee-google
reviewed
Nov 4, 2024
aee-google
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port relevant Chromium code to the Cobalt 25 codebase to allow for
MediaSourceobjects on a Dedicated Worker to render frames on aHTMLMediaElementowned by the main browser thread.Usage of this feature is gated behind the
MediaSource.EnableInWorkersH5VCC flag. In addition, the
MediaElement.EnableUsingMediaSourceBufferedRangeandMediaElement.EnableUsingMediaSourceAttachmentMethodsflags are alsorequired as pre-requisite features.
This commit does introduce mutex locks to the
SourceBufferandMediaSourceclasses that cannot be fully gated behind H5VCC flags. However, current
usage of both classes is contained to single-threaded usecases. As such,
the mutex lock code should be an effective no-op.
This is based off of the following Chromium commits:
b/338425382