Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of test targets #4464

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
88d9c2d
Add script that calculates test targets based on gn deps
oxve Dec 26, 2024
3256ba1
Add set -x to GH action
oxve Dec 27, 2024
285c048
Add json output and fix printed values
oxve Dec 27, 2024
b2d47f4
Pass test target json to test runner
oxve Dec 27, 2024
0f0cad4
Fix output attribute name
oxve Dec 27, 2024
a7e0be8
Use jq raw output
oxve Dec 27, 2024
dfcaff1
Comments, minor polish
oxve Dec 28, 2024
ebd307b
Fix unit tests
oxve Dec 28, 2024
485cb46
Remove suites that do not build with cobalt config
oxve Dec 28, 2024
34ebe1a
Use jq raw output
oxve Dec 28, 2024
6ce5cee
Fix if conditions related to test steps
oxve Dec 28, 2024
57ea000
Rename paramerers to better reflect the usage
oxve Dec 28, 2024
f845b15
Always try to run tests
oxve Dec 28, 2024
cbfff95
Fix test invocation
oxve Dec 28, 2024
848fc94
Fix archive step
oxve Dec 28, 2024
58ba9cc
Fix curly brackets
oxve Dec 28, 2024
02926f9
Fix upload inputs
oxve Dec 28, 2024
4d1c298
Attempt to fix quotes
oxve Dec 28, 2024
eeb310f
Remove duplicates from artifacts tar
oxve Dec 29, 2024
d552346
Fix more input variable names
oxve Dec 29, 2024
ad0ceb2
Remove gn warnings from json output
oxve Dec 29, 2024
7d11d37
Move inclusion of test_targets.json to after the out folder is prepended
oxve Dec 29, 2024
2be54dd
Comment and var rename
oxve Dec 29, 2024
dd464ae
Don't require curly brace to be alone on a line
oxve Dec 29, 2024
035465f
DEVELOPER MODE
oxve Dec 29, 2024
dfe8727
Break out root target to env var, append to test.deps
oxve Dec 29, 2024
efbb05d
Move sed to its own line for clarity
oxve Dec 29, 2024
e5b9394
Make root target configurable per platform
oxve Dec 29, 2024
a363fdf
Fix type hint, add argparse description
oxve Dec 31, 2024
48fe2c2
Exclude nodes outside of dependency tree when looking for test targets
oxve Dec 31, 2024
4fb3fd2
Add root targets for android
oxve Jan 2, 2025
2ebd440
Improve comments, minor refactor
oxve Jan 2, 2025
c044ba3
Merge branch 'main' of github.com:youtube/cobalt into test-targets
oxve Jan 7, 2025
7e65b41
Revert "DEVELOPER MODE"
oxve Jan 7, 2025
8f3fcb3
Fix test_root_target if condition
oxve Jan 7, 2025
5ca18de
Fix quotes
oxve Jan 9, 2025
eb89441
Merge branch 'main' of github.com:youtube/cobalt into test-targets
oxve Jan 9, 2025
e5c1252
Squashed commit of the following:
oxve Jan 10, 2025
a3f9542
Merge branch 'main' of github.com:youtube/cobalt into test-targets
oxve Jan 10, 2025
169f716
Merge branch 'main' of github.com:youtube/cobalt into test-targets
oxve Jan 15, 2025
2ed3656
DEBUG: Print dep chain that included test target
oxve Jan 16, 2025
5b5959d
Remove always()
oxve Jan 16, 2025
a60f533
Merge branch 'main' of github.com:youtube/cobalt into test-targets
oxve Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move sed to its own line for clarity
oxve committed Dec 29, 2024
commit efbb05d2d74e262774d88af9d43bcd418b5169c8
3 changes: 2 additions & 1 deletion .github/actions/build/action.yaml
Original file line number Diff line number Diff line change
@@ -55,8 +55,9 @@ runs:
run: |
set -x
cd src
gn desc out/${{ matrix.platform }}_${{ matrix.config }}/ "*" --format=json > gn_desc.json
# Trim any warning gn printed before the json (all lines above the first curly brace).
gn desc out/${{ matrix.platform }}_${{ matrix.config }}/ "*" --format=json | sed -n '/^{/,$p' > gn_desc.json
sed -n '/^{/,$p' -i gn_desc.json
vpython3 cobalt/build/test_targets.py --root-target="${ROOT_TARGET}" --gn-json=gn_desc.json --json-output > "${TEST_TARGETS_JSON_FILE}"
echo "TEST_TARGETS_JSON_FILE=${TEST_TARGETS_JSON_FILE}" >> $GITHUB_ENV
shell: bash