-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run update check if channel is set to be the same #4521
Conversation
4cb2a4b
to
755ea37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to add unit test to at least chrome/updater code?
Yes, efforts were made to enable unit tests for the updater, but it was not complete because the team was pulled to other issues with higher priorities. Certain unit tests of the updater are enabled: https://source.corp.google.com/h/lbshell-internal/cobalt_src/+/COBALT:chrome/updater/BUILD.gn;l=108 Chrobalt is a a good chance to re-initiate this effort. I'll put it on the workstream doc as a P2. |
Replied as: Yes, efforts were made to enable unit tests for the updater, but it was not complete because the team was pulled to other issues with higher priorities. Certain unit tests of the updater are enabled: source.corp.google.com/h/lbshell-internal/cobalt_src/+/COBALT:chrome/updater/BUILD.gn;l=108 Chrobalt is a a good chance to re-initiate this effort. I'll put it on the workstream doc as a P2.
If SetUpdaterChannel is called with the same channel as the current channel, an update check is forced just like the channel has changed, as long as the channel is not "prod". b/381954273 Change-Id: I042ea07029c56b810f7b4e273fe621d1ab75a9e2
If SetUpdaterChannel is called with the same channel as the current channel, an update check is forced to check for available update on the channel.
b/381954273