Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run update check if channel is set to be the same #4521

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

yuying-y
Copy link
Contributor

@yuying-y yuying-y commented Dec 3, 2024

If SetUpdaterChannel is called with the same channel as the current channel, an update check is forced to check for available update on the channel.

b/381954273

@yuying-y yuying-y force-pushed the friction branch 2 times, most recently from 4cb2a4b to 755ea37 Compare December 5, 2024 23:38
Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to add unit test to at least chrome/updater code?

chrome/updater/updater_module.cc Outdated Show resolved Hide resolved
components/update_client/update_checker.cc Outdated Show resolved Hide resolved
components/update_client/update_checker.cc Outdated Show resolved Hide resolved
cobalt/h5vcc/h5vcc_updater.cc Outdated Show resolved Hide resolved
@yuying-y
Copy link
Contributor Author

yuying-y commented Dec 6, 2024

Any chance to add unit test to at least chrome/updater code?

Yes, efforts were made to enable unit tests for the updater, but it was not complete because the team was pulled to other issues with higher priorities. Certain unit tests of the updater are enabled: https://source.corp.google.com/h/lbshell-internal/cobalt_src/+/COBALT:chrome/updater/BUILD.gn;l=108

Chrobalt is a a good chance to re-initiate this effort. I'll put it on the workstream doc as a P2.

@yuying-y yuying-y requested a review from johnxwork December 10, 2024 22:59
cobalt/h5vcc/h5vcc_updater.cc Show resolved Hide resolved
chrome/updater/configurator.cc Show resolved Hide resolved
@yuying-y yuying-y dismissed yell0wd0g’s stale review December 12, 2024 00:13

Replied as: Yes, efforts were made to enable unit tests for the updater, but it was not complete because the team was pulled to other issues with higher priorities. Certain unit tests of the updater are enabled: source.corp.google.com/h/lbshell-internal/cobalt_src/+/COBALT:chrome/updater/BUILD.gn;l=108 Chrobalt is a a good chance to re-initiate this effort. I'll put it on the workstream doc as a P2.

If SetUpdaterChannel is called with the same channel as the current
channel, an update check is forced just like the channel has changed, as
long as the channel is not "prod".

b/381954273

Change-Id: I042ea07029c56b810f7b4e273fe621d1ab75a9e2
@yuying-y yuying-y enabled auto-merge (squash) December 12, 2024 00:17
@yuying-y yuying-y merged commit 5d0bf09 into youtube:25.lts.1+ Dec 12, 2024
300 of 301 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants