Ensure correct destruction order for FileProxy. #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the base::FileProxy in FileFetcher is destroyed before the TaskRunner that it's posting to from the destructor. This may help with some of the ANRs. b/304601532
jellefoks
force-pushed
the
destroy_fileproxy_first
branch
from
fae1b9b to
64c011a
Compare
andrewsavage1
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the base::FileProxy in FileFetcher is destroyed before the TaskRunner that it's posting to from the destructor.
This may help with some of the ANRs.
b/304601532