Ozone working branch 2 #4538
Draft
Ozone working branch 2 #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yell0wd0g
reviewed
Dec 9, 2024
cobalt/cobalt.cc
Outdated
| "--user-level-memory-pressure-signal-params", | ||
| "https://www.youtube.com/tv" | ||
| }); | ||
| constexpr auto cobalt_args = std::to_array<const char*>( |
There was a problem hiding this comment.
Playing around with this, the current enable_vulkan=false is not enough to disallow vulkan usage in Cobalt builds; a --disable-features=Vulkan needs to be added to the command line here (this is probably an oversight upstream).
TyHolc
force-pushed
the
ozone_working_branch_2
branch
from
0d2654e to
164464d
Compare
Add flags required to run the Starboard implementation of Ozone to avoid needing to pass them for every run.
TyHolc
force-pushed
the
ozone_working_branch_2
branch
from
d66d7ac to
76fa89e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.