Breakdemo #4556
Draft
Breakdemo #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
commented
Dec 11, 2024
| @@ -514,6 +524,24 @@ int Application::RunLoop() { | |||
| return error_level_; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is just copy from above broken in 3
kaidokert
commented
Dec 11, 2024
| #if SB_API_VERSION >= 15 | ||
| explicit Application(SbEventHandleCallback sb_event_handle_callback); | ||
| explicit Application(SbEventHandleCallback sb_event_handle_callback, | ||
| bool blocking = true); |
There was a problem hiding this comment.
Adding an arg isn't actually needed. Blocking version doesn't need to exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick dumb / simple demo for how to take the loop ownership away from Starboard Application object wrapper.
Intentionally obtuse / simple - we have no reason to have both blocking/nonblocking versions.