-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch to disable progressive support #4564
Conversation
1. Adds a runtime switch "--disable_progressive_playback" that will prevent progressive media playback. When set, Cobalt will reject CanPlayType() queries for progressive formats, or will report an error before a ProgressiveDemuxer is constructed. 2. Rearranges methods in `CanPlayTypeHandlerStarboard` to match the declaration order in `CanPlayTypeHandler`. b/382791540
My understanding of the "runtime switch" is to enable/disable progressive support via h5vcc, but the pr uses command line switch. @xiaomings to correct me if that's not correct. |
We may consider to use h5vcc switch --> base_feature --> enable/disable media feature, as base_feature is the way Chromium uses to enable/disable feature. (cc @yell0wd0g) We should define how we are going to add switch for Cobalt. |
I can add an H5vcc switch to this PR |
The H5vcc switch is in. @borongc are you suggesting we use |
I got confused with this PR #4547. For this PR for C25, we should use h5vcc flag for this. |
Maybe we don't need this switch in C26, given that we are going to experiment on C25 first. We can keep progressive support in C26 (without the disable switch), and remove the support completely when the C25 metrics is in? |
That should be fine - the C26 change is small and can be easily merged anytime if we need to |
cc @yell0wd0g shall we add the progressive switch in C25 first in case we decide to remove support entirely in C26? |
window.h5vcc.settings.set("Media.DisableProgressivePlayback", true)
to disable progressive playback, andwindow.h5vcc.settings.set("Media.DisableProgressivePlayback", false)
to reenable it.CanPlayTypeHandlerStarboard
to match the declaration order inCanPlayTypeHandler
.b/382791540