[media] Turn SbPlayerPrivate into an interface #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
force-pushed
the
sbplayer_interface
branch
from
97c8228 to
317ef3b
Compare
borongc
reviewed
Dec 14, 2024
xiaomings
force-pushed
the
sbplayer_interface
branch
from
317ef3b to
8610872
Compare
yell0wd0g
reviewed
Dec 14, 2024
This allows us to move the implementation to a sub-class named SbPlayerPrivateImpl in namespace starboard::shared::starboard::player, which has the following benefits: 1. It allows the implementation to use symbols inside the starboard namespace directly. 2. By moving concrete implementation from the global namespace into a nested namespace, a binary can make use of two implementations (each in their own namespaces), e.g. experimenting on them. b/327287075
xiaomings
force-pushed
the
sbplayer_interface
branch
from
8610872 to
c4afa0c
Compare
|
Done, and I also make all overridden methods final. |
borongc
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to move the implementation to a sub-class named SbPlayerPrivateImpl in namespace starboard::shared::starboard::player, which has the following benefits:
b/327287075