Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WebAudio #4577

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Support WebAudio #4577

merged 6 commits into from
Jan 17, 2025

Conversation

sideb0ard
Copy link
Contributor

@sideb0ard sideb0ard commented Dec 13, 2024 •
edited
Loading

Implement SbAudioSink based WebAudioDevice.

b/340599896

Tested on a Kirkwood device by running:
https://github.com/youtube/cobalt/tree/25.lts.1%2B/cobalt/demos/content/web-audio-demo
and
https://webaudiodemos.appspot.com/oscilloscope/index.html

@sideb0ard sideb0ard requested a review from a team as a code owner December 13, 2024 20:12
@sideb0ard sideb0ard marked this pull request as draft December 18, 2024 23:15
@xiaomings xiaomings self-requested a review December 23, 2024 23:39
@sideb0ard sideb0ard changed the title WIP Support WebAudio Dec 24, 2024
@sideb0ard sideb0ard marked this pull request as ready for review December 30, 2024 21:52
@sideb0ard sideb0ard requested a review from a team as a code owner December 30, 2024 21:52
niranjanyardi
niranjanyardi approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from open comments, lgtm

@sideb0ard sideb0ard requested review from yell0wd0g and borongc January 9, 2025 23:35
@sideb0ard sideb0ard requested a review from borongc January 10, 2025 20:41
xiaomings
xiaomings reviewed Jan 14, 2025
View reviewed changes
@sideb0ard sideb0ard requested a review from xiaomings January 15, 2025 17:00
xiaomings
xiaomings reviewed Jan 15, 2025
View reviewed changes
sideb0ard
sideb0ard commented Jan 16, 2025
View reviewed changes
Copy link
Contributor Author

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one outstanding issue for resampler. Working on that now!

xiaomings
xiaomings approved these changes Jan 16, 2025
View reviewed changes
@sideb0ard sideb0ard merged commit 7826288 into youtube:main Jan 17, 2025
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niranjanyardi niranjanyardi niranjanyardi approved these changes

@andrewsavage1 andrewsavage1 andrewsavage1 left review comments

@xiaomings xiaomings xiaomings approved these changes

@dahlstrom-g dahlstrom-g Awaiting requested review from dahlstrom-g dahlstrom-g was automatically assigned from youtube/cobalt-3p-repository-owners

@yell0wd0g yell0wd0g Awaiting requested review from yell0wd0g

@borongc borongc Awaiting requested review from borongc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sideb0ard @yell0wd0g @xiaomings @niranjanyardi @andrewsavage1 @borongc